From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53EDAC19759 for ; Thu, 1 Aug 2019 21:36:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 243B52064A for ; Thu, 1 Aug 2019 21:36:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564695400; bh=iiI4sT9zcK5ZzoAg0ZjWXALrJaDjNWtGmWpUma1O8UM=; h=From:To:Cc:Subject:Date:List-ID:From; b=0I6qP+EDl2O/2vQUUjS5TciyMh3jq6ZTQug8zk5nFpYne7yi4mxcLx77ES9Xs5k+g 6q2XQ8onvRO8NVekBg8TGtRbaWrwl+89fYvqevvGBXsypCbX406hoDZHwWIwHyl4JQ j2bljS9ViNXO71ksamZBPmrZh3exDFYDDySeu7Vc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389212AbfHAVgj (ORCPT ); Thu, 1 Aug 2019 17:36:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:34672 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731662AbfHAVgi (ORCPT ); Thu, 1 Aug 2019 17:36:38 -0400 Received: from kenny.it.cumulusnetworks.com. (fw.cumulusnetworks.com [216.129.126.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 147CE2064A; Thu, 1 Aug 2019 21:36:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564695398; bh=iiI4sT9zcK5ZzoAg0ZjWXALrJaDjNWtGmWpUma1O8UM=; h=From:To:Cc:Subject:Date:From; b=CFFX8+W3IOUWJtAQf9JRLCmCT3dUMO/Uf0n4z6RkjNyq/Zl4pwZaQaxV+mpwgqBAU iQyuCckG1iQQ45FRYS4qGCNLxxbC3PHW3pcAln3mtqojCJgkgkO/Sb6XPUBCSknIL1 jNmfhZ57Y5LHdkZudTNRpHk1MIXMupCH1Sd9TGsk= From: David Ahern To: davem@davemloft.net Cc: netdev@vger.kernel.org, David Ahern Subject: [PATCH net] ipv6: Fix unbalanced rcu locking in rt6_update_exception_stamp_rt Date: Thu, 1 Aug 2019 14:36:35 -0700 Message-Id: <20190801213635.9278-1-dsahern@kernel.org> X-Mailer: git-send-email 2.11.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: David Ahern The nexthop path in rt6_update_exception_stamp_rt needs to call rcu_read_unlock if it fails to find a fib6_nh match rather than just returning. Fixes: e659ba31d806 ("ipv6: Handle all fib6_nh in a nexthop in exception handling") Signed-off-by: David Ahern --- net/ipv6/route.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index e49fec767a10..fd059e08785a 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -1951,7 +1951,7 @@ static void rt6_update_exception_stamp_rt(struct rt6_info *rt) nexthop_for_each_fib6_nh(from->nh, fib6_nh_find_match, &arg); if (!arg.match) - return; + goto unlock; fib6_nh = arg.match; } else { fib6_nh = from->fib6_nh; -- 2.11.0