From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74ABAC32750 for ; Fri, 2 Aug 2019 16:48:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2B86C2087E for ; Fri, 2 Aug 2019 16:48:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ruNAu8Q4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390864AbfHBQs1 (ORCPT ); Fri, 2 Aug 2019 12:48:27 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:35221 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388211AbfHBQs0 (ORCPT ); Fri, 2 Aug 2019 12:48:26 -0400 Received: by mail-pl1-f193.google.com with SMTP id w24so33856657plp.2; Fri, 02 Aug 2019 09:48:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=zgdMzC369eZOQe1nP+iQAA42VLiDWQP08Q0sXkidxik=; b=ruNAu8Q4kz/Oqylu3Vf/XNFv3MVpTPCZ7Toy2kjaT1OZZYNs4cThGnhTNLZWC1FdOF LEwnQxtlHCvTaruVuyz6IvsJUz13fQSTrwQarbi1j/qyAB1tmTV9r3qjOmfhCHtMhQQj U/r9NQLOtZGqpwAjqzZJvi/RJBGyEbQDsZUuVIK9IrW6a3xlnOR4JXGsESnfWvsg1jY8 MPCdsAOfw0g3TwTBL8YbnxLDlZrSBr1rlsTuHQXI4F/8aWeOo9WV5TRrVBOiBfBDzuvX pL9xhrfMffG/9oO5ytLpEPnFmeaIXUYDplFXYCTvpZFoKwH612fx6FD75YU01YNW+pUV h9JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=zgdMzC369eZOQe1nP+iQAA42VLiDWQP08Q0sXkidxik=; b=OjM5YZAW+jxqsb6UUiRfq+UFDH7DnTvaWr3VyRWzWiHAnmhYqnXvPUg5bO3G4i4hYV lvjFJyESispYjmhKNcq3giBgBwBYF8VECEiAxNfRwCr+3kHWptSUeJolZjy4yENI/HbT wCiX4yjZ+iti8ad8RnuUyv00m2j97U0LSpl+KjjASyevjEbErWneFE7Ka/3PVU/LZu+H 6aUSkD7wzgfbSBs27/zRbtTEMSyiynOwGWia6MjeUZVofcszjRu1Avxs45mdIMRHrC5r bjf1hiDS5rbnULZeRbIIFX6LeESgqQmr/3CQTG4OgJiv6jPDZHoZSYt8/uKlJCc99OmA qPcg== X-Gm-Message-State: APjAAAUWtWENj759jPILSrriMA1gDJtdYXNWmEa7xPqSLY5Bmp4zXPp3 bGQYxyuargd0DPxEUyF7SDEJbuuOYW3Gag== X-Google-Smtp-Source: APXvYqzXwBykUHq15uR6yKW2w4CDTWp4aur1Yf9oRArKODUF/AVkqNA2xxygNqrTuoc0aSdNMz70SA== X-Received: by 2002:a17:902:740a:: with SMTP id g10mr133221668pll.82.1564764506283; Fri, 02 Aug 2019 09:48:26 -0700 (PDT) Received: from suzukaze.ipads-lab.se.sjtu.edu.cn ([89.31.126.54]) by smtp.gmail.com with ESMTPSA id f3sm126220150pfg.165.2019.08.02.09.48.24 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 02 Aug 2019 09:48:25 -0700 (PDT) From: Chuhong Yuan Cc: "David S . Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Chuhong Yuan Subject: [PATCH v2] mkiss: Use refcount_t for refcount Date: Sat, 3 Aug 2019 00:48:21 +0800 Message-Id: <20190802164821.20189-1-hslester96@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org refcount_t is better for reference counters since its implementation can prevent overflows. So convert atomic_t ref counters to refcount_t. Signed-off-by: Chuhong Yuan --- Changes in v2: - Add #include. drivers/net/hamradio/mkiss.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/net/hamradio/mkiss.c b/drivers/net/hamradio/mkiss.c index 442018ccd65e..c5bfa19ddb93 100644 --- a/drivers/net/hamradio/mkiss.c +++ b/drivers/net/hamradio/mkiss.c @@ -25,6 +25,7 @@ #include #include #include +#include #include @@ -70,7 +71,7 @@ struct mkiss { #define CRC_MODE_FLEX_TEST 3 #define CRC_MODE_SMACK_TEST 4 - atomic_t refcnt; + refcount_t refcnt; struct completion dead; }; @@ -668,7 +669,7 @@ static struct mkiss *mkiss_get(struct tty_struct *tty) read_lock(&disc_data_lock); ax = tty->disc_data; if (ax) - atomic_inc(&ax->refcnt); + refcount_inc(&ax->refcnt); read_unlock(&disc_data_lock); return ax; @@ -676,7 +677,7 @@ static struct mkiss *mkiss_get(struct tty_struct *tty) static void mkiss_put(struct mkiss *ax) { - if (atomic_dec_and_test(&ax->refcnt)) + if (refcount_dec_and_test(&ax->refcnt)) complete(&ax->dead); } @@ -704,7 +705,7 @@ static int mkiss_open(struct tty_struct *tty) ax->dev = dev; spin_lock_init(&ax->buflock); - atomic_set(&ax->refcnt, 1); + refcount_set(&ax->refcnt, 1); init_completion(&ax->dead); ax->tty = tty; @@ -784,7 +785,7 @@ static void mkiss_close(struct tty_struct *tty) * We have now ensured that nobody can start using ap from now on, but * we have to wait for all existing users to finish. */ - if (!atomic_dec_and_test(&ax->refcnt)) + if (!refcount_dec_and_test(&ax->refcnt)) wait_for_completion(&ax->dead); /* * Halt the transmit queue so that a new transmit cannot scribble -- 2.20.1