From: Greg KH <gregkh@linuxfoundation.org>
To: Jose Carlos Cazarin Filho <joseespiriki@gmail.com>
Cc: isdn@linux-pingi.de, devel@driverdev.osuosl.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] isdn: hysdn: Fix error spaces around '*'
Date: Sat, 3 Aug 2019 08:32:46 +0200 [thread overview]
Message-ID: <20190803063246.GA10186@kroah.com> (raw)
In-Reply-To: <20190802195602.28414-1-joseespiriki@gmail.com>
On Fri, Aug 02, 2019 at 07:56:02PM +0000, Jose Carlos Cazarin Filho wrote:
> Fix checkpath error:
> CHECK: spaces preferred around that '*' (ctx:WxV)
> +extern hysdn_card *card_root; /* pointer to first card */
>
> Signed-off-by: Jose Carlos Cazarin Filho <joseespiriki@gmail.com>
> ---
> Hello all!
> This is my first commit to the Linux Kernel, I'm doing this to learn and be able
> to contribute more in the future
> Peace all!
>
> drivers/staging/isdn/hysdn/hysdn_defs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/isdn/hysdn/hysdn_defs.h b/drivers/staging/isdn/hysdn/hysdn_defs.h
> index cdac46a21..f20150d62 100644
> --- a/drivers/staging/isdn/hysdn/hysdn_defs.h
> +++ b/drivers/staging/isdn/hysdn/hysdn_defs.h
> @@ -220,7 +220,7 @@ typedef struct hycapictrl_info hycapictrl_info;
> /*****************/
> /* exported vars */
> /*****************/
> -extern hysdn_card *card_root; /* pointer to first card */
> +extern hysdn_card * card_root; /* pointer to first card */
The original code here is correct, checkpatch must be reporting this
incorrectly.
thanks,
greg k-h
next prev parent reply other threads:[~2019-08-03 6:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 19:56 [PATCH] isdn: hysdn: Fix error spaces around '*' Jose Carlos Cazarin Filho
2019-08-02 21:55 ` Stephen Hemminger
2019-08-02 22:05 ` Joe Perches
2019-08-08 16:39 ` Greg KH
2019-08-08 16:40 ` Greg KH
2019-08-08 16:48 ` Joe Perches
2019-08-03 6:32 ` Greg KH [this message]
2019-08-03 11:15 ` Joe Perches
2019-08-03 11:24 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190803063246.GA10186@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=isdn@linux-pingi.de \
--cc=joseespiriki@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).