From: David Miller <davem@davemloft.net>
To: maowenan@huawei.com
Cc: socketcan@hartkopp.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next v3] net: can: Fix compiling warnings for two functions
Date: Mon, 05 Aug 2019 10:30:02 -0700 (PDT) [thread overview]
Message-ID: <20190805.103002.641507066504156536.davem@davemloft.net> (raw)
In-Reply-To: <20190805115744.112440-1-maowenan@huawei.com>
From: Mao Wenan <maowenan@huawei.com>
Date: Mon, 5 Aug 2019 19:57:44 +0800
> @@ -1680,7 +1680,7 @@ static int bcm_recvmsg(struct socket *sock, struct msghdr *msg, size_t size,
> return size;
> }
>
> -int bcm_sock_no_ioctlcmd(struct socket *sock, unsigned int cmd,
> +static int bcm_sock_no_ioctlcmd(struct socket *sock, unsigned int cmd,
> unsigned long arg)
The alignment of the second line here needs to be adjusted, it must start
precisely at the first column after the openning parenthesis of the first
line.
Same for the other change in this patch.
next prev parent reply other threads:[~2019-08-05 17:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 3:36 [PATCH net-next] net: can: Fix compiling warning Mao Wenan
2019-08-02 8:10 ` Oliver Hartkopp
2019-08-02 8:39 ` maowenan
2019-08-06 13:52 ` Dan Carpenter
2019-08-06 16:41 ` Oliver Hartkopp
2019-08-07 10:50 ` Dan Carpenter
2019-08-12 17:19 ` Kees Cook
2019-08-13 12:48 ` Dan Carpenter
2019-08-12 5:48 ` maowenan
2019-08-12 8:11 ` Oliver Hartkopp
2019-08-02 8:59 ` Sergei Shtylyov
2019-08-05 1:13 ` maowenan
2019-08-05 1:26 ` [PATCH net-next v2] " Mao Wenan
2019-08-05 10:56 ` [v2] " Markus Elfring
2019-08-05 11:57 ` [PATCH net-next v3] net: can: Fix compiling warnings for two functions Mao Wenan
2019-08-05 17:30 ` David Miller [this message]
2019-08-06 1:37 ` [PATCH net-next v4] " Mao Wenan
2019-08-06 11:37 ` [v4] " Markus Elfring
2019-08-06 14:40 ` [PATCH net-next v5] net: can: Fix sparse " Mao Wenan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190805.103002.641507066504156536.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maowenan@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).