From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33C34C433FF for ; Mon, 5 Aug 2019 17:58:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 13AC320880 for ; Mon, 5 Aug 2019 17:58:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730035AbfHER6C (ORCPT ); Mon, 5 Aug 2019 13:58:02 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:59952 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726779AbfHER6B (ORCPT ); Mon, 5 Aug 2019 13:58:01 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1D8D7154086FA; Mon, 5 Aug 2019 10:58:01 -0700 (PDT) Date: Mon, 05 Aug 2019 10:58:00 -0700 (PDT) Message-Id: <20190805.105800.1380680189003158228.davem@davemloft.net> To: mcroce@redhat.com Cc: netdev@vger.kernel.org, miquel.raynal@free-electrons.com, linux-kernel@vger.kernel.org, lorenzo@kernel.org, antoine.tenart@bootlin.com, maxime.chevallier@bootlin.com Subject: Re: [PATCH net] mvpp2: fix panic on module removal From: David Miller In-Reply-To: <20190731183116.4791-1-mcroce@redhat.com> References: <20190731183116.4791-1-mcroce@redhat.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 05 Aug 2019 10:58:01 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Matteo Croce Date: Wed, 31 Jul 2019 20:31:16 +0200 > mvpp2 uses a delayed workqueue to gather traffic statistics. > On module removal the workqueue can be destroyed before calling > cancel_delayed_work_sync() on its works. > Fix it by moving the destroy_workqueue() call after mvpp2_port_remove(). Please post a new version with the flush_workqueue() removed.