From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A15C1C433FF for ; Mon, 5 Aug 2019 18:20:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7AF9A216B7 for ; Mon, 5 Aug 2019 18:20:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730212AbfHESUI (ORCPT ); Mon, 5 Aug 2019 14:20:08 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:60342 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728831AbfHESUI (ORCPT ); Mon, 5 Aug 2019 14:20:08 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id A5B2C1540E332; Mon, 5 Aug 2019 11:20:07 -0700 (PDT) Date: Mon, 05 Aug 2019 11:20:07 -0700 (PDT) Message-Id: <20190805.112007.2076762521602269526.davem@davemloft.net> To: mpelland@starry.com Cc: netdev@vger.kernel.org, maxime.chevallier@bootlin.com, antoine.tenart@bootlin.com Subject: Re: [PATCH 1/2] net: mvpp2: implement RXAUI support From: David Miller In-Reply-To: <20190801204523.26454-2-mpelland@starry.com> References: <20190801204523.26454-1-mpelland@starry.com> <20190801204523.26454-2-mpelland@starry.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 05 Aug 2019 11:20:07 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Matt Pelland Date: Thu, 1 Aug 2019 16:45:22 -0400 > +static void mvpp22_gop_init_rxaui(struct mvpp2_port *port) > +{ > + struct mvpp2 *priv = port->priv; > + void __iomem *xpcs = priv->iface_base + MVPP22_XPCS_BASE(port->gop_id); > + u32 val; Reverse christmas tree please.