From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDBDCC0650F for ; Mon, 5 Aug 2019 20:19:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BD18F216F4 for ; Mon, 5 Aug 2019 20:19:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730665AbfHEUTE (ORCPT ); Mon, 5 Aug 2019 16:19:04 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:33658 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727460AbfHEUTD (ORCPT ); Mon, 5 Aug 2019 16:19:03 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id C80BD154316F3; Mon, 5 Aug 2019 13:19:02 -0700 (PDT) Date: Mon, 05 Aug 2019 13:19:02 -0700 (PDT) Message-Id: <20190805.131902.224245258223919215.davem@davemloft.net> To: csully@google.com Cc: netdev@vger.kernel.org, sagis@google.com Subject: Re: [PATCH net] gve: Fix case where desc_cnt and data_cnt can get out of sync From: David Miller In-Reply-To: <20190801230731.142536-1-csully@google.com> References: <20190801230731.142536-1-csully@google.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 05 Aug 2019 13:19:02 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Catherine Sullivan Date: Thu, 1 Aug 2019 16:07:31 -0700 > desc_cnt and data_cnt should always be equal. In the case of a dropped > packet desc_cnt was still getting updated (correctly), data_cnt > was not. To eliminate this bug and prevent it from recurring this > patch combines them into one ring level cnt. > > Signed-off-by: Catherine Sullivan > Reviewed-by: Sagi Shahar Applied.