From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33DFCC433FF for ; Mon, 5 Aug 2019 20:24:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0F687208E3 for ; Mon, 5 Aug 2019 20:24:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730569AbfHEUYF (ORCPT ); Mon, 5 Aug 2019 16:24:05 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:33720 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728831AbfHEUYF (ORCPT ); Mon, 5 Aug 2019 16:24:05 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 8631715431997; Mon, 5 Aug 2019 13:24:04 -0700 (PDT) Date: Mon, 05 Aug 2019 13:24:03 -0700 (PDT) Message-Id: <20190805.132403.543467679705520777.davem@davemloft.net> To: kgraul@linux.ibm.com Cc: netdev@vger.kernel.org, linux-s390@vger.kernel.org, gor@linux.ibm.com, heiko.carstens@de.ibm.com, raspl@linux.ibm.com, ubraun@linux.ibm.com Subject: Re: [PATCH net] net/smc: do not schedule tx_work in SMC_CLOSED state From: David Miller In-Reply-To: <20190802081638.56207-1-kgraul@linux.ibm.com> References: <20190802081638.56207-1-kgraul@linux.ibm.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 05 Aug 2019 13:24:04 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Karsten Graul Date: Fri, 2 Aug 2019 10:16:38 +0200 > From: Ursula Braun > > The setsockopts options TCP_NODELAY and TCP_CORK may schedule the > tx worker. Make sure the socket is not yet moved into SMC_CLOSED > state (for instance by a shutdown SHUT_RDWR call). > > Reported-by: syzbot+92209502e7aab127c75f@syzkaller.appspotmail.com > Reported-by: syzbot+b972214bb803a343f4fe@syzkaller.appspotmail.com > Fixes: 01d2f7e2cdd31 ("net/smc: sockopts TCP_NODELAY and TCP_CORK") > Signed-off-by: Ursula Braun > Signed-off-by: Karsten Graul Applied and queued up for -stable.