From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Peter Wu <peter@lekensteyn.nl>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
netdev@vger.kernel.org, Stanislav Fomichev <sdf@google.com>,
Quentin Monnet <quentin.monnet@netronome.com>
Subject: Re: [PATCH v2] tools: bpftool: fix reading from /proc/config.gz
Date: Mon, 5 Aug 2019 18:59:40 -0700 [thread overview]
Message-ID: <20190805185940.786af579@cakuba.netronome.com> (raw)
In-Reply-To: <20190806010702.3303-1-peter@lekensteyn.nl>
On Tue, 6 Aug 2019 02:07:02 +0100, Peter Wu wrote:
> /proc/config has never existed as far as I can see, but /proc/config.gz
> is present on Arch Linux. Execute an external gunzip program to avoid
> linking to zlib and rework the option scanning code since a pipe is not
> seekable. This also fixes a file handle leak on some error paths.
Please post the fix for the handle leak separately against the bpf tree.
> Fixes: 4567b983f78c ("tools: bpftool: add probes for kernel configuration options")
Other than the leak I'm not sure this qualifies as a bug.
Reading config.gz was consciously left to be implemented later.
> Cc: Quentin Monnet <quentin.monnet@netronome.com>
> Signed-off-by: Peter Wu <peter@lekensteyn.nl>
> ---
> v2: fix style (reorder vars as reverse xmas tree, rename function,
> braces), fallback to /proc/config.gz if uname() fails.
>
> Hi,
>
> Although Stanislav and Jakub suggested to use zlib in v1, I have not
> implemented that yet since the current patch is quite minimal.
>
> Using zlib instead of executing an external gzip program would like add
> another 100-150 lines. It likely requires a bigger rewrite to avoid
> getline() assuming that no temporary file is used for the uncompressed
> config. If zlib is desired, I would suggest doing it in another patch.
>
> Thoughts?
I'd rather avoid the fork and pipe. We already implicitly link against
zlib for libelf etc.
prev parent reply other threads:[~2019-08-06 2:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 1:07 [PATCH v2] tools: bpftool: fix reading from /proc/config.gz Peter Wu
2019-08-06 1:59 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190805185940.786af579@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=peter@lekensteyn.nl \
--cc=quentin.monnet@netronome.com \
--cc=sdf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox