From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0925C31E40 for ; Tue, 6 Aug 2019 21:38:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BA5EE2189F for ; Tue, 6 Aug 2019 21:38:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728729AbfHFVif (ORCPT ); Tue, 6 Aug 2019 17:38:35 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:50248 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726085AbfHFVid (ORCPT ); Tue, 6 Aug 2019 17:38:33 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 693D31423AA7D; Tue, 6 Aug 2019 14:38:33 -0700 (PDT) Date: Tue, 06 Aug 2019 14:38:32 -0700 (PDT) Message-Id: <20190806.143832.528331834164499899.davem@davemloft.net> To: pkusunyifeng@gmail.com Cc: netdev@vger.kernel.org, pshelar@ovn.org, gvrose8192@gmail.com Subject: Re: [PATCH net-next v2] openvswitch: Print error when ovs_execute_actions() fails From: David Miller In-Reply-To: <1564973771-22542-1-git-send-email-pkusunyifeng@gmail.com> References: <1564973771-22542-1-git-send-email-pkusunyifeng@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 06 Aug 2019 14:38:33 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yifeng Sun Date: Sun, 4 Aug 2019 19:56:11 -0700 > Currently in function ovs_dp_process_packet(), return values of > ovs_execute_actions() are silently discarded. This patch prints out > an debug message when error happens so as to provide helpful hints > for debugging. > --- > v1->v2: Fixed according to Pravin's review. Applied.