From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: ap420073@gmail.com, netdev@vger.kernel.org, nhorman@redhat.com,
sassmann@redhat.com, andrewx.bowers@intel.com
Subject: Re: [net] ixgbe: fix possible deadlock in ixgbe_service_task()
Date: Tue, 06 Aug 2019 14:51:04 -0700 (PDT) [thread overview]
Message-ID: <20190806.145104.1044990165298646882.davem@davemloft.net> (raw)
In-Reply-To: <20190805200403.23512-1-jeffrey.t.kirsher@intel.com>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Mon, 5 Aug 2019 13:04:03 -0700
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> index cbaf712d6529..3386e752e458 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> @@ -7898,9 +7898,7 @@ static void ixgbe_service_task(struct work_struct *work)
> }
> if (ixgbe_check_fw_error(adapter)) {
> if (!test_bit(__IXGBE_DOWN, &adapter->state)) {
> - rtnl_lock();
> unregister_netdev(adapter->netdev);
> - rtnl_unlock();
> }
Please remove the (now unnecessary) curly braces for this basic block.
Thank you.
next prev parent reply other threads:[~2019-08-06 23:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 20:04 [net] ixgbe: fix possible deadlock in ixgbe_service_task() Jeff Kirsher
2019-08-06 21:51 ` David Miller [this message]
2019-08-07 6:08 ` Taehee Yoo
2019-08-08 16:36 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190806.145104.1044990165298646882.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrewx.bowers@intel.com \
--cc=ap420073@gmail.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).