From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13AEDC433FF for ; Tue, 6 Aug 2019 17:31:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D76DD20C01 for ; Tue, 6 Aug 2019 17:31:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="nQeImNQS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732960AbfHFRbE (ORCPT ); Tue, 6 Aug 2019 13:31:04 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:42935 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729161AbfHFRbE (ORCPT ); Tue, 6 Aug 2019 13:31:04 -0400 Received: by mail-qt1-f196.google.com with SMTP id h18so85393590qtm.9 for ; Tue, 06 Aug 2019 10:31:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=jOF8HX7d3k1WX7dM1V9b8nyJlK40/ytZ9jNB9hmM9SA=; b=nQeImNQS/VMoOULddOgvO2gUqY92iC5CO3d+w6pi+0qtLRcFm1eXSgkuGvR7csDVMz S3a3kmBuRrpjSU+jKxgkpkhbQDWKt2Nsq9rnKIgxEnZeiCTC8ri/0NTgRPK8h0VDmSwN 7an0UkF2/FatzfjzqPdaSHfozAUBfoBTZB1J8Q7Mgwb7/JIHdQnAr8RL0N85GMeZlbg8 /rdMvJ5RICSWA2PiZolsxXISRyjGEmHrdBcbIidIC8CKRV/9WlUU4cNXnltNv3+NTkuO JQy85Sal00pbreUYzZHZMl+U2UiHTA6wP2KL/08ArrsT/6JUD2rkTvvDEl7ir+HhGf3Y zx1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=jOF8HX7d3k1WX7dM1V9b8nyJlK40/ytZ9jNB9hmM9SA=; b=DkiT+Id5qDazrY/8/rJw9/WBudvdcXT67lVgM1f5SzwZ+HhD/Yb9502MVj1p20LjWD 1bdU99TTeKL4zeFpkWKeMgLg3kT6rSTEWikcFfl+/ayYSfZUSH2tuoNtOnLGB60D0k0i T9/gEeJSUvS7RXhOHtgSgfi41m+93vOPISy01kCQfJMzuXW89THtRBbdCnGozRBmZpRv /PyasWGRf8ktGZnG/0yxi4NY7gRk1ObUmd0HlAqJhU/ItVS3Ad7rTzYurfnrEMxDDPNn iGcCy3Vdu1MtGXyu+tIaYq/hHzczz9E77NPkDoFK4m2VKCE0Uiy8l3EAa8835vsZFyuy Zfzw== X-Gm-Message-State: APjAAAVTnlc5yvF5/ESd0IDKdVxGF8l8bhdCUZmS/f+EIEuy2CZCx91p 8Rq1LqDRlEEwGdfqnOVOkXXD7w== X-Google-Smtp-Source: APXvYqydfNW6VQe3QJLlhVyMY7LD2VdLv18RznvBSPB+dUhBxuNiXXy+N60ZePa04UjZ6hpqlgPk1Q== X-Received: by 2002:a0c:f5cc:: with SMTP id q12mr4143708qvm.79.1565112663672; Tue, 06 Aug 2019 10:31:03 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id k25sm47224230qta.78.2019.08.06.10.31.02 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 06 Aug 2019 10:31:03 -0700 (PDT) Date: Tue, 6 Aug 2019 10:30:35 -0700 From: Jakub Kicinski To: Greg Kroah-Hartman Cc: netdev@vger.kernel.org, "David S. Miller" , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Edwin Peer , Yangtao Li , Simon Horman , oss-drivers@netronome.com Subject: Re: [PATCH 08/17] nfp: no need to check return value of debugfs_create functions Message-ID: <20190806103035.60bacd35@cakuba.netronome.com> In-Reply-To: <20190806170049.GA12269@kroah.com> References: <20190806161128.31232-1-gregkh@linuxfoundation.org> <20190806161128.31232-9-gregkh@linuxfoundation.org> <20190806095008.57007f2f@cakuba.netronome.com> <20190806170049.GA12269@kroah.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 6 Aug 2019 19:00:49 +0200, Greg Kroah-Hartman wrote: > On Tue, Aug 06, 2019 at 09:50:08AM -0700, Jakub Kicinski wrote: > > On Tue, 6 Aug 2019 18:11:19 +0200, Greg Kroah-Hartman wrote: > > > When calling debugfs functions, there is no need to ever check the > > > return value. The function can work or not, but the code logic should > > > never do something different based on this. > > > > > > Cc: Jakub Kicinski > > > Cc: "David S. Miller" > > > Cc: Alexei Starovoitov > > > Cc: Daniel Borkmann > > > Cc: Jesper Dangaard Brouer > > > Cc: John Fastabend > > > Cc: Edwin Peer > > > Cc: Yangtao Li > > > Cc: Simon Horman > > > Cc: oss-drivers@netronome.com > > > Cc: netdev@vger.kernel.org > > > Signed-off-by: Greg Kroah-Hartman > > > > Acked-by: Jakub Kicinski > > > > I take it this is the case since commit ff9fb72bc077 ("debugfs: return > > error values, not NULL")? I.e. v5.0? It'd be useful to know for backport > > purposes. > > You were always safe to ignore debugfs calls before that, but in 5.0 and > then 5.2 we got a bit more "robust" with some internal debugfs logic to > make it even easier. These can be backported to 2.6.11+ if you really > want to, no functionality should change. Oh sorry! I meant vendor out-of-tree driver backport. We all maintain a tarball version of the drivers that compile on old kernels, I was mostly wondering from that perspective. > But why would you want to backport them? This really isn't a "bugfix" > for a stable kernel. No one should ever noticed the difference except > for less memory being used. Right, it wouldn't really help to do an upstream backport.