From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2015EC31E40 for ; Tue, 6 Aug 2019 19:13:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E8D9D208C3 for ; Tue, 6 Aug 2019 19:13:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="SGfjoPA4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726345AbfHFTNR (ORCPT ); Tue, 6 Aug 2019 15:13:17 -0400 Received: from mail-qk1-f195.google.com ([209.85.222.195]:40449 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725906AbfHFTNQ (ORCPT ); Tue, 6 Aug 2019 15:13:16 -0400 Received: by mail-qk1-f195.google.com with SMTP id s145so63815493qke.7 for ; Tue, 06 Aug 2019 12:13:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=VnZDZzBAZi4D2nAqWC3qKDXkK4ME9tg6Ir4ylUba4jg=; b=SGfjoPA4i1Mm/bTUKSTpZMu1+1qm1orBY6Je1wobz3GeFacipSg3vaAISShedMFloX LklV3gXrz4aVn2LkyVj4UGkiuug9d6vhoRh51P1R8K08xXmni+YlDqLz8dI3NLFPUtKm oXY6zQlFVCaE3xrmablLByoFZQyld45ysxfuYu+Xc5ngbYZpKCyfE+FXoPrChbqAQHHM DtLsZmCMf0xURVExyIwdvQDIWIY39E/4jCu6x3sLTdiAC3HbVr/wFL4DQJkY+DtHK78U xpyCC6A7pGy23rjcJ8F5xwjRU6ri2zszNhOdqCpClLxZzFBTnmnjXiZE5BLiiVrPSHxA AKVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=VnZDZzBAZi4D2nAqWC3qKDXkK4ME9tg6Ir4ylUba4jg=; b=kverrLfbXE+hgjTVt0MAqrjALF3tqJM23VZyqzF8U1aXCsQH4PBvT4kPrxfIjbtKFB v1LUkyP/19vrAqn2CXZfEWtqou+h3K5WGrqWuo4y2iK9oVqrppnNm5ScFmzdH1fte3yC G1zSd1djaAgPdT8UwQgGFtjhb7rnTq0HdgwaS/IWjA6OhEVILhq6rXMTmBinDirVyMyF 1qfouMM/cGU9r12fnTxqfkwfG6Tk4kGsjN0mum+C3AhtWzEXkV7aaai2EL74YcpFVcOs p9eZzZ+Ysb2h6AogqVdkeDLL7NroQYIkH+ZBza4Zb3X8oodcvKDhpwafUIV6XJ8SPRKw V5FQ== X-Gm-Message-State: APjAAAVkLYsqD3eFZj0I9k5engunDlfGslxV54fK4HDAjytKADX/rieb yIlPwy+hRnBXohkmyvQtCVMCMQ== X-Google-Smtp-Source: APXvYqwTM9Nkb/KONg55InkFyQG+V6Xua7EUBriiyRj1o00r4ii18WpOUrQTfkoxnkYCgxcEOVoOUQ== X-Received: by 2002:a37:311:: with SMTP id 17mr4499484qkd.466.1565118790235; Tue, 06 Aug 2019 12:13:10 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id z19sm40441271qtu.43.2019.08.06.12.13.08 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 06 Aug 2019 12:13:10 -0700 (PDT) Date: Tue, 6 Aug 2019 12:12:42 -0700 From: Jakub Kicinski To: Dexuan Cui Cc: "netdev@vger.kernel.org" , "David S. Miller" , Haiyang Zhang , Stephen Hemminger , "sashal@kernel.org" , KY Srinivasan , Michael Kelley , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "olaf@aepfle.de" , "apw@canonical.com" , "jasowang@redhat.com" , vkuznets , "marcelo.cerri@canonical.com" Subject: Re: [PATCH net] hv_netvsc: Fix a warning of suspicious RCU usage Message-ID: <20190806121242.141c2324@cakuba.netronome.com> In-Reply-To: References: Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 6 Aug 2019 05:17:44 +0000, Dexuan Cui wrote: > This fixes a warning of "suspicious rcu_dereference_check() usage" > when nload runs. > > Signed-off-by: Stephen Hemminger > Signed-off-by: Dexuan Cui Minor change in behaviour would perhaps be worth acknowledging in the commit message (since you check ndev for NULL later now), and a Fixes tag would be good. But the looks pretty straightforward and correct!