From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4008C31E40 for ; Tue, 6 Aug 2019 22:10:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B5A9C21872 for ; Tue, 6 Aug 2019 22:10:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="DiNlS0lM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727359AbfHFWKe (ORCPT ); Tue, 6 Aug 2019 18:10:34 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:33545 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727022AbfHFWKe (ORCPT ); Tue, 6 Aug 2019 18:10:34 -0400 Received: by mail-qt1-f195.google.com with SMTP id r6so82050187qtt.0 for ; Tue, 06 Aug 2019 15:10:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=k5MlzirpZYamcdWz7AWbdCMy4iWhcebC9AZ/B4iX4vQ=; b=DiNlS0lMBqKQ8N8XEC9ggrn/qkh+UA2hvtCs3VnCp/1FDuRFh8AWh0IrPMQTSI1seh ILTlQ69cQuC8/r1/C++1zZs61I17M+qy5aejqcX8ujbltSmqJ1JxPV4twEW8bb/XA75B R2wDG0iLFvBwzqcChOWMGDsxHqs5u1o207qqjuEv/znX7OKV48xSF6SE1i9X2jzYisqS zSyAFrx2evZTUZNrvCIVwVGYMifT8jRUHFC7oRXrAH6Hf/lj4EaJLSciLzD6e6GSoyc6 KQpvphQctVTQIdodoQQq/kfH+9K0S98Umqp8zkpdkLtRZmbCCklHtYljPnaonLTZ5sEK Okug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=k5MlzirpZYamcdWz7AWbdCMy4iWhcebC9AZ/B4iX4vQ=; b=eV9Yb1t1ImnWZ3rWTnutDWJ7buylZvsw4uRlRE2ihA8D++zdYFGpqZylLLIuanonrG cR93iJAocJav5PmMYJzqoxXFp3GLqW+r5lEFfo6hZMFp5E9hF+LtIAHjOW+oqpxpdcff sDgDTb0xvS2UiHiNEbsYoW7LxGfntZtxcSxrg5Gj8O0XR9QbalPeKRp8UrCT/G8rcnRW tCV4fembVYyMvLttt09W6GRHjRShP3kbHrLlmLQk1TjoyqfzPE3uOdOLVISZwN27kqyF bZlwmrn3eFVl4ye5Nwoill3V7945gm8i6Bzpyp6Bz5D3XCROkSOkPJKkA5N09HgFIARE 9Nrw== X-Gm-Message-State: APjAAAUwbCdGZsuL0XrGp735tq3Y4gQOGhnZ6+wUDFT3O7gCfl/hCLiN K5s8k/SMLkV0D1fPqDtn+coS1Q== X-Google-Smtp-Source: APXvYqxJVIiFVF2MvxFJ5nvgTIbxn2d6z4r2/R64xlzNBTDE0v1VaGLNq/YntAbOLyQiOadkdwKc7w== X-Received: by 2002:aed:3987:: with SMTP id m7mr5096695qte.56.1565129433194; Tue, 06 Aug 2019 15:10:33 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id t26sm47547788qtc.95.2019.08.06.15.10.32 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 06 Aug 2019 15:10:33 -0700 (PDT) Date: Tue, 6 Aug 2019 15:10:07 -0700 From: Jakub Kicinski To: Hayes Wang Cc: , , , Subject: Re: [PATCH net-next 5/5] r8152: change rx_frag_head_sz and rx_max_agg_num dynamically Message-ID: <20190806151007.75a8dd2c@cakuba.netronome.com> In-Reply-To: <1394712342-15778-294-albertk@realtek.com> References: <1394712342-15778-289-albertk@realtek.com> <1394712342-15778-294-albertk@realtek.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 6 Aug 2019 19:18:04 +0800, Hayes Wang wrote: > Let rx_frag_head_sz and rx_max_agg_num could be modified dynamically > through the sysfs. > > Signed-off-by: Hayes Wang Please don't expose those via sysfs. Ethtool's copybreak and descriptor count should be applicable here, I think.