From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB125C433FF for ; Tue, 6 Aug 2019 16:08:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 870DB20679 for ; Tue, 6 Aug 2019 16:08:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387624AbfHFQIB (ORCPT ); Tue, 6 Aug 2019 12:08:01 -0400 Received: from correo.us.es ([193.147.175.20]:45728 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732203AbfHFQIB (ORCPT ); Tue, 6 Aug 2019 12:08:01 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 33CDCDA704 for ; Tue, 6 Aug 2019 18:07:59 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 23C9A5C023 for ; Tue, 6 Aug 2019 18:07:59 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 189AE576C8; Tue, 6 Aug 2019 18:07:59 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 1B356DA704; Tue, 6 Aug 2019 18:07:57 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Tue, 06 Aug 2019 18:07:57 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (149.103.108.93.rev.vodafone.pt [93.108.103.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 85CAC4265A31; Tue, 6 Aug 2019 18:07:56 +0200 (CEST) Date: Tue, 6 Aug 2019 18:07:53 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: wenxu@ucloud.cn Cc: jakub.kicinski@netronome.com, jiri@resnulli.us, netfilter-devel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next v6 5/6] flow_offload: support get multi-subsystem block Message-ID: <20190806160753.rry2pupezz2frktt@salvia> References: <1564925041-23530-1-git-send-email-wenxu@ucloud.cn> <1564925041-23530-6-git-send-email-wenxu@ucloud.cn> <20190806160509.qrldfktw37qqorae@salvia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190806160509.qrldfktw37qqorae@salvia> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Aug 06, 2019 at 06:05:09PM +0200, Pablo Neira Ayuso wrote: > On Sun, Aug 04, 2019 at 09:24:00PM +0800, wenxu@ucloud.cn wrote: > > From: wenxu > > > > It provide a callback list to find the blocks of tc > > and nft subsystems > > > > Signed-off-by: wenxu > > --- > > v6: new patch > > > > include/net/flow_offload.h | 10 +++++++++- > > net/core/flow_offload.c | 47 +++++++++++++++++++++++++++++++++------------- > > net/sched/cls_api.c | 9 ++++++++- > > 3 files changed, 51 insertions(+), 15 deletions(-) > > > > diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h > > index 8f1a7b8..6022dd0 100644 > > --- a/include/net/flow_offload.h > > +++ b/include/net/flow_offload.h > > @@ -375,6 +375,15 @@ typedef void flow_indr_block_ing_cmd_t(struct net_device *dev, > > void *cb_priv, > > enum flow_block_command command); > > > > +struct flow_indr_block_ing_entry { > > + flow_indr_block_ing_cmd_t *cb; > > + struct list_head list; > > +}; > > + > > +void flow_indr_add_block_ing_cb(struct flow_indr_block_ing_entry *entry); > > + > > +void flow_indr_del_block_ing_cb(struct flow_indr_block_ing_entry *entry); > > Twice the same? I overlook the _add_ _del_, sorry.