From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C539AC433FF for ; Tue, 6 Aug 2019 16:11:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 90B8F208C3 for ; Tue, 6 Aug 2019 16:11:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565107906; bh=YXredxS6VuGAA2GZ7NTzDgJWsoabv2GNy155CgHoO1I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=bdvX5bgGKu2Wr7mXrgJsmbd7nZjL11p+9netn82GqHyilT/m0F8doNnFcsSt/aEj/ 2ZMSpUE3a3sT0d7Wjv2T9YPyynpaQNrjBCmfK1Sa6G8gHpgvRljCwuBkcL5YzAb40Q uhiHKTbePrQFfW04FtLAyAyYPSuMY+SAUITbeFBI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387782AbfHFQLp (ORCPT ); Tue, 6 Aug 2019 12:11:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:50046 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732598AbfHFQLp (ORCPT ); Tue, 6 Aug 2019 12:11:45 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7FBB5208C3; Tue, 6 Aug 2019 16:11:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565107904; bh=YXredxS6VuGAA2GZ7NTzDgJWsoabv2GNy155CgHoO1I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=g94Ed9s6udz6gp7a8vL015D3XK2MxcmZdBBn5LbO85G/3fCIws2WK4ricS/MzX0dN 2oFAPEll00d+D3uZqatbpJCmOk5izxTg+8sfrL8IobV9w0X3XtXHGJN6STuT4dIGIZ GIx6y7KjE1dpvDJv7MMKGJ4YFkS/vmhjGxCgnLNU= From: Greg Kroah-Hartman To: netdev@vger.kernel.org Cc: Greg Kroah-Hartman , "David S. Miller" , Stefan Wahren , Michael Heimpold , Yangtao Li Subject: [PATCH 11/17] qca: no need to check return value of debugfs_create functions Date: Tue, 6 Aug 2019 18:11:22 +0200 Message-Id: <20190806161128.31232-12-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190806161128.31232-1-gregkh@linuxfoundation.org> References: <20190806161128.31232-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: "David S. Miller" Cc: Stefan Wahren Cc: Michael Heimpold Cc: Yangtao Li Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/qualcomm/qca_debug.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/qca_debug.c b/drivers/net/ethernet/qualcomm/qca_debug.c index bcb890b18a94..702aa217a27a 100644 --- a/drivers/net/ethernet/qualcomm/qca_debug.c +++ b/drivers/net/ethernet/qualcomm/qca_debug.c @@ -131,17 +131,10 @@ DEFINE_SHOW_ATTRIBUTE(qcaspi_info); void qcaspi_init_device_debugfs(struct qcaspi *qca) { - struct dentry *device_root; + qca->device_root = debugfs_create_dir(dev_name(&qca->net_dev->dev), + NULL); - device_root = debugfs_create_dir(dev_name(&qca->net_dev->dev), NULL); - qca->device_root = device_root; - - if (IS_ERR(device_root) || !device_root) { - pr_warn("failed to create debugfs directory for %s\n", - dev_name(&qca->net_dev->dev)); - return; - } - debugfs_create_file("info", S_IFREG | 0444, device_root, qca, + debugfs_create_file("info", S_IFREG | 0444, qca->device_root, qca, &qcaspi_info_fops); } -- 2.22.0