From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87A15C31E40 for ; Tue, 6 Aug 2019 16:11:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5332720679 for ; Tue, 6 Aug 2019 16:11:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565107918; bh=umuTiq5eKXtMZ+yj06jUD2SoWujiGAXU2OudWD/g9e0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=0TuKdCI0tToLaLqf86hR6RPKzD0NWHaoE10ZxpAFbQqqmS8WldfsIg3GthfenYsBY xBQz264r5+NIiVxGRWZkeR7oy2LbIMirJWRoxzMgjp/Z4dujMQC51bQlIA+9Yeogja WBsVH/vYhFRnVo8T5iVnkFjeOkoj4UDEfdqpRhsI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387817AbfHFQL5 (ORCPT ); Tue, 6 Aug 2019 12:11:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:50238 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387799AbfHFQLz (ORCPT ); Tue, 6 Aug 2019 12:11:55 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D066B20679; Tue, 6 Aug 2019 16:11:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565107914; bh=umuTiq5eKXtMZ+yj06jUD2SoWujiGAXU2OudWD/g9e0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bycdcAWROi+X5bmXap8z1xqEqgOgmmTlzUDLFVuqTb4gyHnyZf0whcpAnurLp9HkP zh2vNZxlMPjr2fNMmdVSod8T3MB5tY2OHfHjMo1ZRB1ooAtdhQ0h9RgqOInNC466Wd 8xxNf15SQRWR/TPeit54XGsuphmVTY5bk07Ky1UE= From: Greg Kroah-Hartman To: netdev@vger.kernel.org Cc: Greg Kroah-Hartman , Jeff Kirsher , "David S. Miller" , intel-wired-lan@lists.osuosl.org Subject: [PATCH 15/17] i40e: no need to check return value of debugfs_create functions Date: Tue, 6 Aug 2019 18:11:26 +0200 Message-Id: <20190806161128.31232-16-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190806161128.31232-1-gregkh@linuxfoundation.org> References: <20190806161128.31232-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Jeff Kirsher Cc: "David S. Miller" Cc: intel-wired-lan@lists.osuosl.org Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- .../net/ethernet/intel/i40e/i40e_debugfs.c | 21 ++++--------------- 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c index 55d20acfcf70..0df9454b3315 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c +++ b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c @@ -1732,29 +1732,16 @@ static const struct file_operations i40e_dbg_netdev_ops_fops = { **/ void i40e_dbg_pf_init(struct i40e_pf *pf) { - struct dentry *pfile; const char *name = pci_name(pf->pdev); const struct device *dev = &pf->pdev->dev; pf->i40e_dbg_pf = debugfs_create_dir(name, i40e_dbg_root); - if (!pf->i40e_dbg_pf) - return; - - pfile = debugfs_create_file("command", 0600, pf->i40e_dbg_pf, pf, - &i40e_dbg_command_fops); - if (!pfile) - goto create_failed; - pfile = debugfs_create_file("netdev_ops", 0600, pf->i40e_dbg_pf, pf, - &i40e_dbg_netdev_ops_fops); - if (!pfile) - goto create_failed; + debugfs_create_file("command", 0600, pf->i40e_dbg_pf, pf, + &i40e_dbg_command_fops); - return; - -create_failed: - dev_info(dev, "debugfs dir/file for %s failed\n", name); - debugfs_remove_recursive(pf->i40e_dbg_pf); + debugfs_create_file("netdev_ops", 0600, pf->i40e_dbg_pf, pf, + &i40e_dbg_netdev_ops_fops); } /** -- 2.22.0