From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 189C1C31E40 for ; Tue, 6 Aug 2019 19:48:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DC7FD208C3 for ; Tue, 6 Aug 2019 19:48:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565120938; bh=slWIq3N1nPtYwZC+AEnxAVvGWm91oTWMsjgEegD39q8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=kxuIoNEA60jjVbIVOLjnnTT4u+T81+cOWczcl50utPodUccw5y7GhC4f6QohQloFU l2IMZ3K0bXnvVBZUF0besLFrq35HY5/snRl7meXGGZkCuBYQD3uSdntdjKH1yMJulH c4hRSbFWV5HH5yeUOnLEn3ELamqDu9UGKl6Ao+0w= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726133AbfHFTs6 (ORCPT ); Tue, 6 Aug 2019 15:48:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:54740 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725798AbfHFTs6 (ORCPT ); Tue, 6 Aug 2019 15:48:58 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 14F3620880; Tue, 6 Aug 2019 19:48:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565120936; bh=slWIq3N1nPtYwZC+AEnxAVvGWm91oTWMsjgEegD39q8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Zpg8Q0izVTIhVt5cASXdj9fiRe8tIy9DFenqqh34T55wwAtoCFTMoX3ppdvy7FMLi htCDIsQBnojw9p7l9qQFEclS6ElKs6XbVmx5XQwN3Ot1xHsS9e7fa38WnHPI9Loxpw VHqlPY8Eek978qnU+HhKNWeqkoDDFXWxS/fMWSpc= Date: Tue, 6 Aug 2019 21:48:54 +0200 From: Greg Kroah-Hartman To: Stefan Schmidt Cc: netdev@vger.kernel.org, Michael Hennerich , Alexander Aring , "David S. Miller" , Harry Morris , linux-wpan@vger.kernel.org Subject: Re: [PATCH 17/17] ieee802154: no need to check return value of debugfs_create functions Message-ID: <20190806194854.GA12401@kroah.com> References: <20190806161128.31232-1-gregkh@linuxfoundation.org> <20190806161128.31232-18-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Aug 06, 2019 at 09:22:43PM +0200, Stefan Schmidt wrote: > Hello. > > On 06.08.19 18:11, Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic should > > never do something different based on this. > > > > Cc: Michael Hennerich > > Cc: Alexander Aring > > Cc: Stefan Schmidt > > Cc: "David S. Miller" > > Cc: Harry Morris > > Cc: linux-wpan@vger.kernel.org > > Cc: netdev@vger.kernel.org > > Signed-off-by: Greg Kroah-Hartman > > --- > > drivers/net/ieee802154/adf7242.c | 12 +++--------- > > drivers/net/ieee802154/at86rf230.c | 20 +++++--------------- > > drivers/net/ieee802154/ca8210.c | 9 +-------- > > 3 files changed, 9 insertions(+), 32 deletions(-) > > > > diff --git a/drivers/net/ieee802154/adf7242.c b/drivers/net/ieee802154/adf7242.c > > index c9392d70e639..7b95add2235a 100644 > > --- a/drivers/net/ieee802154/adf7242.c > > +++ b/drivers/net/ieee802154/adf7242.c > > @@ -1158,7 +1158,7 @@ static int adf7242_stats_show(struct seq_file *file, void *offset) > > return 0; > > } > > > > -static int adf7242_debugfs_init(struct adf7242_local *lp) > > +static void adf7242_debugfs_init(struct adf7242_local *lp) > > { > > char debugfs_dir_name[DNAME_INLINE_LEN + 1] = "adf7242-"; > > struct dentry *stats; > > A quick look over the code indicates that the stats variable can go as > well now as it is only used in the now removed code. Odd 0-day never gave me a build warning for it, sorry about that. > > > @@ -1166,15 +1166,9 @@ static int adf7242_debugfs_init(struct adf7242_local *lp) > > strncat(debugfs_dir_name, dev_name(&lp->spi->dev), DNAME_INLINE_LEN); > > > > lp->debugfs_root = debugfs_create_dir(debugfs_dir_name, NULL); > > - if (IS_ERR_OR_NULL(lp->debugfs_root)) > > - return PTR_ERR_OR_ZERO(lp->debugfs_root); > > > > - stats = debugfs_create_devm_seqfile(&lp->spi->dev, "status", > > - lp->debugfs_root, > > - adf7242_stats_show); > > - return PTR_ERR_OR_ZERO(stats); > > - > > - return 0; > > + debugfs_create_devm_seqfile(&lp->spi->dev, "status", lp->debugfs_root, > > + adf7242_stats_show); > > } > > > > static const s32 adf7242_powers[] = { > > diff --git a/drivers/net/ieee802154/at86rf230.c b/drivers/net/ieee802154/at86rf230.c > > index 595cf7e2a651..7d67f41387f5 100644 > > --- a/drivers/net/ieee802154/at86rf230.c > > +++ b/drivers/net/ieee802154/at86rf230.c > > @@ -1626,24 +1626,16 @@ static int at86rf230_stats_show(struct seq_file *file, void *offset) > > } > > DEFINE_SHOW_ATTRIBUTE(at86rf230_stats); > > > > -static int at86rf230_debugfs_init(struct at86rf230_local *lp) > > +static void at86rf230_debugfs_init(struct at86rf230_local *lp) > > { > > char debugfs_dir_name[DNAME_INLINE_LEN + 1] = "at86rf230-"; > > - struct dentry *stats; > > > > strncat(debugfs_dir_name, dev_name(&lp->spi->dev), DNAME_INLINE_LEN); > > > > at86rf230_debugfs_root = debugfs_create_dir(debugfs_dir_name, NULL); > > - if (!at86rf230_debugfs_root) > > - return -ENOMEM; > > - > > - stats = debugfs_create_file("trac_stats", 0444, > > - at86rf230_debugfs_root, lp, > > - &at86rf230_stats_fops); > > - if (!stats) > > - return -ENOMEM; > > > > - return 0; > > + debugfs_create_file("trac_stats", 0444, at86rf230_debugfs_root, lp, > > + &at86rf230_stats_fops); > > } > > > > static void at86rf230_debugfs_remove(void) > > @@ -1651,7 +1643,7 @@ static void at86rf230_debugfs_remove(void) > > debugfs_remove_recursive(at86rf230_debugfs_root); > > } > > #else > > -static int at86rf230_debugfs_init(struct at86rf230_local *lp) { return 0; } > > +static void at86rf230_debugfs_init(struct at86rf230_local *lp) { } > > static void at86rf230_debugfs_remove(void) { } > > #endif > > > > @@ -1751,9 +1743,7 @@ static int at86rf230_probe(struct spi_device *spi) > > /* going into sleep by default */ > > at86rf230_sleep(lp); > > > > - rc = at86rf230_debugfs_init(lp); > > - if (rc) > > - goto free_dev; > > + at86rf230_debugfs_init(lp); > > > > rc = ieee802154_register_hw(lp->hw); > > if (rc) > > diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c > > index b188fce3f641..11402dc347db 100644 > > --- a/drivers/net/ieee802154/ca8210.c > > +++ b/drivers/net/ieee802154/ca8210.c > > @@ -3019,14 +3019,7 @@ static int ca8210_test_interface_init(struct ca8210_priv *priv) > > priv, > > &test_int_fops > > ); > > - if (IS_ERR(test->ca8210_dfs_spi_int)) { > > - dev_err( > > - &priv->spi->dev, > > - "Error %ld when creating debugfs node\n", > > - PTR_ERR(test->ca8210_dfs_spi_int) > > - ); > > - return PTR_ERR(test->ca8210_dfs_spi_int); > > - } > > + > > debugfs_create_symlink("ca8210", NULL, node_name); > > init_waitqueue_head(&test->readq); > > return kfifo_alloc( > > > > With a fix for the above included you can have my > > > Acked-by: Stefan Schmidt > > for version 2. I'll fix it up and resend tomorrow, thanks! greg k-h