From: Florian Westphal <fw@strlen.de>
To: Guillaume Nault <gnault@redhat.com>
Cc: netdev@vger.kernel.org, Florian Westphal <fw@strlen.de>,
Eric Dumazet <edumazet@google.com>,
Peter Oskolkov <posk@google.com>,
Alexander Aring <alex.aring@gmail.com>
Subject: Re: [PATCH net] inet: frags: re-introduce skb coalescing for local delivery
Date: Wed, 7 Aug 2019 02:28:32 +0200 [thread overview]
Message-ID: <20190807002832.q4xvst4i4jj6fwst@breakpoint.cc> (raw)
In-Reply-To: <22d8da10c97214edd0677e6478093ad9376180ef.1564758715.git.gnault@redhat.com>
Guillaume Nault <gnault@redhat.com> wrote:
> Before commit d4289fcc9b16 ("net: IP6 defrag: use rbtrees for IPv6
> defrag"), a netperf UDP_STREAM test[0] using big IPv6 datagrams (thus
> generating many fragments) and running over an IPsec tunnel, reported
> more than 6Gbps throughput. After that patch, the same test gets only
> 9Mbps when receiving on a be2net nic (driver can make a big difference
> here, for example, ixgbe doesn't seem to be affected).
>
> By reusing the IPv4 defragmentation code, IPv6 lost fragment coalescing
> (IPv4 fragment coalescing was dropped by commit 14fe22e33462 ("Revert
> "ipv4: use skb coalescing in defragmentation"")).
[..]
> This patch is quite conservative and only coalesces skbs for local
> IPv4 and IPv6 delivery (in order to avoid changing skb geometry when
> forwarding). Coalescing could be extended in the future if need be, as
> more scenarios would probably benefit from it.
No objections from my side, so:
Acked-by: Florian Westphal <fw@strlen.de>
next prev parent reply other threads:[~2019-08-07 0:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 15:15 [PATCH net] inet: frags: re-introduce skb coalescing for local delivery Guillaume Nault
2019-08-06 20:57 ` David Miller
2019-08-07 0:28 ` Florian Westphal [this message]
2019-08-08 22:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190807002832.q4xvst4i4jj6fwst@breakpoint.cc \
--to=fw@strlen.de \
--cc=alex.aring@gmail.com \
--cc=edumazet@google.com \
--cc=gnault@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=posk@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).