netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Antoine Tenart <antoine.tenart@bootlin.com>
To: davem@davemloft.net, richardcochran@gmail.com,
	alexandre.belloni@bootlin.com, UNGLinuxDriver@microchip.com
Cc: Antoine Tenart <antoine.tenart@bootlin.com>,
	netdev@vger.kernel.org, thomas.petazzoni@bootlin.com,
	allan.nielsen@microchip.com
Subject: [PATCH net-next v5 5/6] net: mscc: remove the frame_info cpuq member
Date: Wed,  7 Aug 2019 11:22:13 +0200	[thread overview]
Message-ID: <20190807092214.19936-6-antoine.tenart@bootlin.com> (raw)
In-Reply-To: <20190807092214.19936-1-antoine.tenart@bootlin.com>

In struct frame_info, the cpuq member is never used. This cosmetic patch
removes it from the structure, and from the parsing of the frame header
as it's only set but never used.

Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
---
 drivers/net/ethernet/mscc/ocelot.h       | 1 -
 drivers/net/ethernet/mscc/ocelot_board.c | 1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/mscc/ocelot.h b/drivers/net/ethernet/mscc/ocelot.h
index e0da8b4eddf2..515dee6fa8a6 100644
--- a/drivers/net/ethernet/mscc/ocelot.h
+++ b/drivers/net/ethernet/mscc/ocelot.h
@@ -45,7 +45,6 @@ struct frame_info {
 	u32 len;
 	u16 port;
 	u16 vid;
-	u8 cpuq;
 	u8 tag_type;
 };
 
diff --git a/drivers/net/ethernet/mscc/ocelot_board.c b/drivers/net/ethernet/mscc/ocelot_board.c
index 5e4f1718dd99..df8d15994a89 100644
--- a/drivers/net/ethernet/mscc/ocelot_board.c
+++ b/drivers/net/ethernet/mscc/ocelot_board.c
@@ -33,7 +33,6 @@ static int ocelot_parse_ifh(u32 *_ifh, struct frame_info *info)
 
 	info->port = IFH_EXTRACT_BITFIELD64(ifh[1], 43, 4);
 
-	info->cpuq = IFH_EXTRACT_BITFIELD64(ifh[1], 20, 8);
 	info->tag_type = IFH_EXTRACT_BITFIELD64(ifh[1], 16,  1);
 	info->vid = IFH_EXTRACT_BITFIELD64(ifh[1], 0,  12);
 
-- 
2.21.0


  parent reply	other threads:[~2019-08-07  9:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-07  9:22 [PATCH net-next v5 0/6] net: mscc: PTP Hardware Clock (PHC) support Antoine Tenart
2019-08-07  9:22 ` [PATCH net-next v5 1/6] Documentation/bindings: net: ocelot: document the PTP bank Antoine Tenart
2019-08-10 17:14   ` Andrew Lunn
2019-08-07  9:22 ` [PATCH net-next v5 2/6] Documentation/bindings: net: ocelot: document the PTP ready IRQ Antoine Tenart
2019-08-10 17:15   ` Andrew Lunn
2019-08-07  9:22 ` [PATCH net-next v5 3/6] net: mscc: describe the PTP register range Antoine Tenart
2019-08-10 17:16   ` Andrew Lunn
2019-08-07  9:22 ` [PATCH net-next v5 4/6] net: mscc: improve the frame header parsing readability Antoine Tenart
2019-08-07  9:22 ` Antoine Tenart [this message]
2019-08-10 17:18   ` [PATCH net-next v5 5/6] net: mscc: remove the frame_info cpuq member Andrew Lunn
2019-08-07  9:22 ` [PATCH net-next v5 6/6] net: mscc: PTP Hardware Clock (PHC) support Antoine Tenart
2019-08-10 17:32   ` Andrew Lunn
2019-08-12  8:49     ` Antoine Tenart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190807092214.19936-6-antoine.tenart@bootlin.com \
    --to=antoine.tenart@bootlin.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=allan.nielsen@microchip.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).