From: David Miller <davem@davemloft.net>
To: oneukum@suse.com
Cc: netdev@vger.kernel.org, dsd@gentoo.org, kune@deine-taler.de,
linux-wireless@vger.kernel.org, kvalo@codeaurora.org
Subject: Re: [PATCH] zd1211rw: remove false assertion from zd_mac_clear()
Date: Thu, 08 Aug 2019 11:05:13 -0700 (PDT) [thread overview]
Message-ID: <20190808.110513.1831373344437334072.davem@davemloft.net> (raw)
In-Reply-To: <20190808093203.23752-1-oneukum@suse.com>
From: Oliver Neukum <oneukum@suse.com>
Date: Thu, 8 Aug 2019 11:32:03 +0200
> The function is called before the lock which is asserted was ever used.
> Just remove it.
>
> Reported-by: syzbot+74c65761783d66a9c97c@syzkaller.appspotmail.com
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
Please CC: the appropriate driver maitainers and mailing list as this
is clearly specified in the MAINTAINERS file.
Thank you.
> ---
> drivers/net/wireless/zydas/zd1211rw/zd_mac.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/zydas/zd1211rw/zd_mac.c b/drivers/net/wireless/zydas/zd1211rw/zd_mac.c
> index da7e63fca9f5..a9999d10ae81 100644
> --- a/drivers/net/wireless/zydas/zd1211rw/zd_mac.c
> +++ b/drivers/net/wireless/zydas/zd1211rw/zd_mac.c
> @@ -223,7 +223,6 @@ void zd_mac_clear(struct zd_mac *mac)
> {
> flush_workqueue(zd_workqueue);
> zd_chip_clear(&mac->chip);
> - lockdep_assert_held(&mac->lock);
> ZD_MEMCLEAR(mac, sizeof(struct zd_mac));
> }
>
> --
> 2.16.4
>
prev parent reply other threads:[~2019-08-08 18:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 9:32 [PATCH] zd1211rw: remove false assertion from zd_mac_clear() Oliver Neukum
2019-08-08 18:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190808.110513.1831373344437334072.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsd@gentoo.org \
--cc=kune@deine-taler.de \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox