From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39560C31E40 for ; Fri, 9 Aug 2019 05:01:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 18C6A21743 for ; Fri, 9 Aug 2019 05:01:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405226AbfHIFBM (ORCPT ); Fri, 9 Aug 2019 01:01:12 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:55888 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725879AbfHIFBM (ORCPT ); Fri, 9 Aug 2019 01:01:12 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1D07D140505DB; Thu, 8 Aug 2019 22:01:11 -0700 (PDT) Date: Thu, 08 Aug 2019 22:01:10 -0700 (PDT) Message-Id: <20190808.220110.894522042255176514.davem@davemloft.net> To: ivan.khoronzhuk@linaro.org Cc: vinicius.gomes@intel.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net: sched: sch_taprio: fix memleak in error path for sched list parse From: David Miller In-Reply-To: <20190806224540.24912-1-ivan.khoronzhuk@linaro.org> References: <20190806224540.24912-1-ivan.khoronzhuk@linaro.org> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 08 Aug 2019 22:01:11 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Ivan Khoronzhuk Date: Wed, 7 Aug 2019 01:45:40 +0300 > In error case, all entries should be freed from the sched list > before deleting it. For simplicity use rcu way. > > Fixes: 5a781ccbd19e46 ("tc: Add support for configuring the taprio scheduler") > Acked-by: Vinicius Costa Gomes > Signed-off-by: Ivan Khoronzhuk Applied and queued up for -stable, thank you.