From: Greg KH <gregkh@linuxfoundation.org>
To: Joe Perches <joe@perches.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Jose Carlos Cazarin Filho <joseespiriki@gmail.com>,
isdn@linux-pingi.de, devel@driverdev.osuosl.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] isdn: hysdn: Fix error spaces around '*'
Date: Thu, 8 Aug 2019 18:39:05 +0200 [thread overview]
Message-ID: <20190808163905.GA9224@kroah.com> (raw)
In-Reply-To: <2ecfbf8dda354fe47912446bf5c3fe30ca905aa0.camel@perches.com>
On Fri, Aug 02, 2019 at 03:05:05PM -0700, Joe Perches wrote:
> On Fri, 2019-08-02 at 14:55 -0700, Stephen Hemminger wrote:
> > On Fri, 2 Aug 2019 19:56:02 +0000
> > Jose Carlos Cazarin Filho <joseespiriki@gmail.com> wrote:
> >
> > > Fix checkpath error:
> > > CHECK: spaces preferred around that '*' (ctx:WxV)
> > > +extern hysdn_card *card_root; /* pointer to first card */
> > >
> > > Signed-off-by: Jose Carlos Cazarin Filho <joseespiriki@gmail.com>
> >
> > Read the TODO, these drivers are scheduled for removal, so changes
> > are not helpful at this time.
>
> Maybe better to mark the MAINTAINERS entry obsolete so
> checkpatch bleats a message about unnecessary changes.
> ---
> MAINTAINERS | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 30bf852e6d6b..b5df91032574 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -8628,7 +8628,7 @@ M: Karsten Keil <isdn@linux-pingi.de>
> L: isdn4linux@listserv.isdn4linux.de (subscribers-only)
> L: netdev@vger.kernel.org
> W: http://www.isdn4linux.de
> -S: Odd Fixes
> +S: Obsolete
> F: Documentation/isdn/
> F: drivers/isdn/capi/
> F: drivers/staging/isdn/
>
Good idea, will take this patch now, thanks.
greg k-h
next prev parent reply other threads:[~2019-08-08 16:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 19:56 [PATCH] isdn: hysdn: Fix error spaces around '*' Jose Carlos Cazarin Filho
2019-08-02 21:55 ` Stephen Hemminger
2019-08-02 22:05 ` Joe Perches
2019-08-08 16:39 ` Greg KH [this message]
2019-08-08 16:40 ` Greg KH
2019-08-08 16:48 ` Joe Perches
2019-08-03 6:32 ` Greg KH
2019-08-03 11:15 ` Joe Perches
2019-08-03 11:24 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190808163905.GA9224@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=isdn@linux-pingi.de \
--cc=joe@perches.com \
--cc=joseespiriki@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).