From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, URIBL_SBL,URIBL_SBL_A autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADF74C31E40 for ; Fri, 9 Aug 2019 18:22:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9596E20C01 for ; Fri, 9 Aug 2019 18:22:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407491AbfHISWa (ORCPT ); Fri, 9 Aug 2019 14:22:30 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:36068 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726216AbfHISW3 (ORCPT ); Fri, 9 Aug 2019 14:22:29 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 8F4D1154319AD; Fri, 9 Aug 2019 11:22:28 -0700 (PDT) Date: Fri, 09 Aug 2019 11:22:28 -0700 (PDT) Message-Id: <20190809.112228.285932738589703769.davem@davemloft.net> To: jiri@resnulli.us Cc: netdev@vger.kernel.org, tariqt@mellanox.com, valex@mellanox.com, mlxsw@mellanox.com Subject: Re: [patch net-next] devlink: remove pointless data_len arg from region snapshot create From: David Miller In-Reply-To: <20190809132715.24282-1-jiri@resnulli.us> References: <20190809132715.24282-1-jiri@resnulli.us> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 09 Aug 2019 11:22:28 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jiri Pirko Date: Fri, 9 Aug 2019 15:27:15 +0200 > From: Jiri Pirko > > The size of the snapshot has to be the same as the size of the region, > therefore no need to pass it again during snapshot creation. Remove the > arg and use region->size instead. > > Signed-off-by: Jiri Pirko Applied.