From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: ap420073@gmail.com, netdev@vger.kernel.org, nhorman@redhat.com,
sassmann@redhat.com, andrewx.bowers@intel.com
Subject: Re: [net v2] ixgbe: fix possible deadlock in ixgbe_service_task()
Date: Fri, 09 Aug 2019 13:17:14 -0700 (PDT) [thread overview]
Message-ID: <20190809.131714.21657168204830538.davem@davemloft.net> (raw)
In-Reply-To: <20190808163756.8753-1-jeffrey.t.kirsher@intel.com>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Thu, 8 Aug 2019 09:37:56 -0700
> From: Taehee Yoo <ap420073@gmail.com>
>
> ixgbe_service_task() calls unregister_netdev() under rtnl_lock().
> But unregister_netdev() internally calls rtnl_lock().
> So deadlock would occur.
>
> Fixes: 59dd45d550c5 ("ixgbe: firmware recovery mode")
> Signed-off-by: Taehee Yoo <ap420073@gmail.com>
> Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> ---
> v2: removed unnecessary curly brackets
Applied, thanks everyone.
prev parent reply other threads:[~2019-08-09 20:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 16:37 [net v2] ixgbe: fix possible deadlock in ixgbe_service_task() Jeff Kirsher
2019-08-09 20:17 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190809.131714.21657168204830538.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrewx.bowers@intel.com \
--cc=ap420073@gmail.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).