From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE31FC433FF for ; Fri, 9 Aug 2019 20:17:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8644120B7C for ; Fri, 9 Aug 2019 20:17:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726475AbfHIURP (ORCPT ); Fri, 9 Aug 2019 16:17:15 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:37432 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725860AbfHIURP (ORCPT ); Fri, 9 Aug 2019 16:17:15 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 7F3F414511F69; Fri, 9 Aug 2019 13:17:14 -0700 (PDT) Date: Fri, 09 Aug 2019 13:17:14 -0700 (PDT) Message-Id: <20190809.131714.21657168204830538.davem@davemloft.net> To: jeffrey.t.kirsher@intel.com Cc: ap420073@gmail.com, netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com, andrewx.bowers@intel.com Subject: Re: [net v2] ixgbe: fix possible deadlock in ixgbe_service_task() From: David Miller In-Reply-To: <20190808163756.8753-1-jeffrey.t.kirsher@intel.com> References: <20190808163756.8753-1-jeffrey.t.kirsher@intel.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 09 Aug 2019 13:17:14 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jeff Kirsher Date: Thu, 8 Aug 2019 09:37:56 -0700 > From: Taehee Yoo > > ixgbe_service_task() calls unregister_netdev() under rtnl_lock(). > But unregister_netdev() internally calls rtnl_lock(). > So deadlock would occur. > > Fixes: 59dd45d550c5 ("ixgbe: firmware recovery mode") > Signed-off-by: Taehee Yoo > Tested-by: Andrew Bowers > Signed-off-by: Jeff Kirsher > --- > v2: removed unnecessary curly brackets Applied, thanks everyone.