From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 899C5C433FF for ; Sat, 10 Aug 2019 02:54:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5E0F8217F4 for ; Sat, 10 Aug 2019 02:54:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725927AbfHJCyf (ORCPT ); Fri, 9 Aug 2019 22:54:35 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:41314 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725773AbfHJCye (ORCPT ); Fri, 9 Aug 2019 22:54:34 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 3FD211540269F; Fri, 9 Aug 2019 19:54:34 -0700 (PDT) Date: Fri, 09 Aug 2019 19:54:29 -0700 (PDT) Message-Id: <20190809.195429.334411908499132946.davem@davemloft.net> To: dsahern@kernel.org Cc: netdev@vger.kernel.org, dsahern@gmail.com Subject: Re: [PATCH net-next] selftests: Fix detection of nettest command in fcnal-test From: David Miller In-Reply-To: <20190809231338.29105-1-dsahern@kernel.org> References: <20190809231338.29105-1-dsahern@kernel.org> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 09 Aug 2019 19:54:34 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: David Ahern Date: Fri, 9 Aug 2019 16:13:38 -0700 > From: David Ahern > > Most of the tests run by fcnal-test.sh relies on the nettest command. > Rather than trying to cover all of the individual tests, check for the > binary only at the beginning. > > Also removes the need for log_error which is undefined. > > Fixes: 6f9d5cacfe07 ("selftests: Setup for functional tests for fib and socket lookups") > Signed-off-by: David Ahern Applied, thanks David.