From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15D52C433FF for ; Fri, 9 Aug 2019 12:32:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DCA1E208C3 for ; Fri, 9 Aug 2019 12:32:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565353923; bh=4JqN3jWAXz09YeqxlYxXimJrwjzfobWefS8qprG7tJo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=jFa4tLIpxO+e5REM3DTRl+KOFfnNJLL6udcvcneICHuV7LxtUcJ4E+NIP7wji1wD5 HVoMmoFGgrAumebLDSq/j6+qnk/jQLAykOczRtIlAjoApCJdT1FmJd4cUwLeMDbZ0f 2kqToRLD0ywQ9U84WQKvaNZBa3KhbX2OZbbXz5hM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406978AbfHIMcC (ORCPT ); Fri, 9 Aug 2019 08:32:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:58500 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2406946AbfHIMb7 (ORCPT ); Fri, 9 Aug 2019 08:31:59 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 43F202166E; Fri, 9 Aug 2019 12:31:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565353918; bh=4JqN3jWAXz09YeqxlYxXimJrwjzfobWefS8qprG7tJo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uYo6oNGOqO4y4xvSuBhr7et7iSP/PXjjlBEj9kl4PUrn3sRvP6aCihtpd6j6aKukn A42XsIhQdWguWY9DQI2jqoiNrKOPbdmL3kGS6hAVte4Lss07SzER0L9hedCtm5vBKh nGRKZTMaut/jpM6BIHLgOkZNvcOQOhamgSJ2tZ2g= From: Greg Kroah-Hartman To: netdev@vger.kernel.org Cc: Greg Kroah-Hartman , Mirko Lindner , Stephen Hemminger , "David S. Miller" Subject: [PATCH v2 12/17] skge: no need to check return value of debugfs_create functions Date: Fri, 9 Aug 2019 14:31:03 +0200 Message-Id: <20190809123108.27065-13-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190809123108.27065-1-gregkh@linuxfoundation.org> References: <20190809123108.27065-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Mirko Lindner Cc: Stephen Hemminger Cc: "David S. Miller" Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/marvell/skge.c | 39 +++++++---------------------- 1 file changed, 9 insertions(+), 30 deletions(-) diff --git a/drivers/net/ethernet/marvell/skge.c b/drivers/net/ethernet/marvell/skge.c index 06dffee81e02..0a2ec387a482 100644 --- a/drivers/net/ethernet/marvell/skge.c +++ b/drivers/net/ethernet/marvell/skge.c @@ -3731,7 +3731,6 @@ static int skge_device_event(struct notifier_block *unused, { struct net_device *dev = netdev_notifier_info_to_dev(ptr); struct skge_port *skge; - struct dentry *d; if (dev->netdev_ops->ndo_open != &skge_up || !skge_debug) goto done; @@ -3739,33 +3738,20 @@ static int skge_device_event(struct notifier_block *unused, skge = netdev_priv(dev); switch (event) { case NETDEV_CHANGENAME: - if (skge->debugfs) { - d = debugfs_rename(skge_debug, skge->debugfs, - skge_debug, dev->name); - if (d) - skge->debugfs = d; - else { - netdev_info(dev, "rename failed\n"); - debugfs_remove(skge->debugfs); - } - } + if (skge->debugfs) + skge->debugfs = debugfs_rename(skge_debug, + skge->debugfs, + skge_debug, dev->name); break; case NETDEV_GOING_DOWN: - if (skge->debugfs) { - debugfs_remove(skge->debugfs); - skge->debugfs = NULL; - } + debugfs_remove(skge->debugfs); + skge->debugfs = NULL; break; case NETDEV_UP: - d = debugfs_create_file(dev->name, 0444, - skge_debug, dev, - &skge_debug_fops); - if (!d || IS_ERR(d)) - netdev_info(dev, "debugfs create failed\n"); - else - skge->debugfs = d; + skge->debugfs = debugfs_create_file(dev->name, 0444, skge_debug, + dev, &skge_debug_fops); break; } @@ -3780,15 +3766,8 @@ static struct notifier_block skge_notifier = { static __init void skge_debug_init(void) { - struct dentry *ent; - - ent = debugfs_create_dir("skge", NULL); - if (!ent || IS_ERR(ent)) { - pr_info("debugfs create directory failed\n"); - return; - } + skge_debug = debugfs_create_dir("skge", NULL); - skge_debug = ent; register_netdevice_notifier(&skge_notifier); } -- 2.22.0