From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AF41C433FF for ; Fri, 9 Aug 2019 12:31:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 07867217F4 for ; Fri, 9 Aug 2019 12:31:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565353889; bh=RUsQEza+Ar9N+FJo3L6rYdD5QR6fkUA8bSv2nnoRzf0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=W/U2zTTWID8NfxmJU26DLyyU8aWuZgUQNgfp38gCfNTLqb+rcBswd5JtfiDIzCaY3 o0XdQ3VOVsR3Amq/xJk4cGLPdKYl/ik248nbDbV8YO/CTNV5wfiqGEIKDlQatF4I5S Liq+WPR2sv0f9MHdYyHdzwCCVbwMPU8FuUwfACAk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406891AbfHIMb0 (ORCPT ); Fri, 9 Aug 2019 08:31:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:57832 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2406878AbfHIMbZ (ORCPT ); Fri, 9 Aug 2019 08:31:25 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B01D2217F4; Fri, 9 Aug 2019 12:31:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565353885; bh=RUsQEza+Ar9N+FJo3L6rYdD5QR6fkUA8bSv2nnoRzf0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CDxNDK+1Y++PFgwNEJ9FhKeF17Y7TbQ/Sm3jPAAvvCAuVmA2uekL2hRIzeWhXop/x zoCXAoTi7mEA0ARLruUY1rc4xm+jcRA1zLj3HhPwox53XHgqvkUWuPSVijcR45od7D /s9lGNbaKSZRjCnin81+rEpuOWRcmnPnhaYZYfsM= From: Greg Kroah-Hartman To: netdev@vger.kernel.org Cc: Greg Kroah-Hartman , Jay Vosburgh , Veaceslav Falico , Andy Gospodarek , "David S. Miller" Subject: [PATCH v2 02/17] bonding: no need to print a message if debugfs_create_dir() fails Date: Fri, 9 Aug 2019 14:30:53 +0200 Message-Id: <20190809123108.27065-3-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190809123108.27065-1-gregkh@linuxfoundation.org> References: <20190809123108.27065-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The debugfs core now will print a message if this function fails, so don't duplicate that logic. Also, no need to change the code logic if the call fails either, as no debugfs calls should interrupt normal kernel code for any reason. Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/net/bonding/bond_debugfs.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/bonding/bond_debugfs.c b/drivers/net/bonding/bond_debugfs.c index 1360f1ffe070..f3f86ef68ae0 100644 --- a/drivers/net/bonding/bond_debugfs.c +++ b/drivers/net/bonding/bond_debugfs.c @@ -55,11 +55,6 @@ void bond_debug_register(struct bonding *bond) bond->debug_dir = debugfs_create_dir(bond->dev->name, bonding_debug_root); - if (!bond->debug_dir) { - netdev_warn(bond->dev, "failed to register to debugfs\n"); - return; - } - debugfs_create_file("rlb_hash_table", 0400, bond->debug_dir, bond, &bond_debug_rlb_hash_fops); } -- 2.22.0