netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@idosch.org>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
	nhorman@tuxdriver.com, jiri@mellanox.com, dsahern@gmail.com,
	roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com,
	jakub.kicinski@netronome.com, andy@greyhouse.net,
	f.fainelli@gmail.com, andrew@lunn.ch, vivien.didelot@gmail.com,
	mlxsw@mellanox.com, Ido Schimmel <idosch@mellanox.com>
Subject: Re: [PATCH net-next 00/10] drop_monitor: Capture dropped packets and metadata
Date: Fri, 9 Aug 2019 15:54:18 +0300	[thread overview]
Message-ID: <20190809125418.GB2931@splinter> (raw)
In-Reply-To: <87o90yrar8.fsf@toke.dk>

On Fri, Aug 09, 2019 at 10:41:47AM +0200, Toke Høiland-Jørgensen wrote:
> This is great. Are you planning to add the XDP integration as well? :)

Thanks, Toke. From one of your previous replies I got the impression
that another hook needs to be added in order to catch 'XDP_DROP' as it
is not covered by the 'xdp_exception' tracepoint which only covers
'XDP_ABORTED'. If you can take care of that, I can look into the
integration with drop monitor.

I kept the XDP case in mind while working on the hardware originated
drops and I think that extending drop monitor for this use case should
be relatively straightforward. I will Cc you on the patchset that adds
monitoring of hardware drops and comment with how I think XDP
integration should look like.

  reply	other threads:[~2019-08-09 12:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-07 10:30 [PATCH net-next 00/10] drop_monitor: Capture dropped packets and metadata Ido Schimmel
2019-08-07 10:30 ` [PATCH net-next 01/10] drop_monitor: Split tracing enable / disable to different functions Ido Schimmel
2019-08-07 10:30 ` [PATCH net-next 02/10] drop_monitor: Initialize timer and work item upon tracing enable Ido Schimmel
2019-08-07 10:30 ` [PATCH net-next 03/10] drop_monitor: Reset per-CPU data before starting to trace Ido Schimmel
2019-08-07 10:30 ` [PATCH net-next 04/10] drop_monitor: Require CAP_NET_ADMIN for drop monitor configuration Ido Schimmel
2019-08-07 10:30 ` [PATCH net-next 05/10] drop_monitor: Add alert mode operations Ido Schimmel
2019-08-07 10:30 ` [PATCH net-next 06/10] drop_monitor: Add packet alert mode Ido Schimmel
2019-08-07 10:30 ` [PATCH net-next 07/10] drop_monitor: Allow truncation of dropped packets Ido Schimmel
2019-08-07 10:30 ` [PATCH net-next 08/10] drop_monitor: Add a command to query current configuration Ido Schimmel
2019-08-07 10:30 ` [PATCH net-next 09/10] drop_monitor: Make drop queue length configurable Ido Schimmel
2019-08-07 10:30 ` [PATCH net-next 10/10] drop_monitor: Expose tail drop counter Ido Schimmel
2019-08-08 21:08 ` [PATCH net-next 00/10] drop_monitor: Capture dropped packets and metadata David Ahern
2019-08-09 12:38   ` Ido Schimmel
2019-08-09  8:41 ` Toke Høiland-Jørgensen
2019-08-09 12:54   ` Ido Schimmel [this message]
2019-08-09 18:15     ` Toke Høiland-Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190809125418.GB2931@splinter \
    --to=idosch@idosch.org \
    --cc=andrew@lunn.ch \
    --cc=andy@greyhouse.net \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=idosch@mellanox.com \
    --cc=jakub.kicinski@netronome.com \
    --cc=jiri@mellanox.com \
    --cc=mlxsw@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=nikolay@cumulusnetworks.com \
    --cc=roopa@cumulusnetworks.com \
    --cc=toke@redhat.com \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).