From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: netdev@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH v3 00/17] Networking driver debugfs cleanups
Date: Sat, 10 Aug 2019 12:17:15 +0200 [thread overview]
Message-ID: <20190810101732.26612-1-gregkh@linuxfoundation.org> (raw)
There is no need to test the result of any debugfs call anymore. The
debugfs core warns the user if something fails, and the return value of
a debugfs call can always be fed back into another debugfs call with no
problems.
Also, debugfs is for debugging, so if there are problems with debugfs
(i.e. the system is out of memory) the rest of the kernel should not
change behavior, so testing for debugfs calls is pointless and not the
goal of debugfs at all.
This series cleans up a lot of networking drivers and some wimax code
that was calling debugfs and trying to do something with the return
value that it didn't need to. Removing this logic makes the code
smaller, easier to understand, and use less run-time memory in some
cases, all good things.
The series is against net-next, and have no dependancies between any of
them if they want to go through any random tree/order. Or, if wanted,
I can take them through my driver-core tree where other debugfs cleanups
are being slowly fed during major merge windows.
thanks,
greg k-h
v3: fix build warning in i2400m, I thought I had caught them all :(
add acks from some reviewers
v2: fix up build warnings, it's as if I never even built these. Ugh, so
sorry for wasting people's time with the v1 series. I need to stop
relying on 0-day as it isn't working well anymore :(
Greg Kroah-Hartman (17):
wimax: no need to check return value of debugfs_create functions
bonding: no need to print a message if debugfs_create_dir() fails
mlx5: no need to check return value of debugfs_create functions
xgbe: no need to check return value of debugfs_create functions
bnxt: no need to check return value of debugfs_create functions
cxgb4: no need to check return value of debugfs_create functions
hns3: no need to check return value of debugfs_create functions
nfp: no need to check return value of debugfs_create functions
stmmac: no need to check return value of debugfs_create functions
dpaa2: no need to check return value of debugfs_create functions
qca: no need to check return value of debugfs_create functions
skge: no need to check return value of debugfs_create functions
mvpp2: no need to check return value of debugfs_create functions
fm10k: no need to check return value of debugfs_create functions
i40e: no need to check return value of debugfs_create functions
ixgbe: no need to check return value of debugfs_create functions
ieee802154: no need to check return value of debugfs_create functions
drivers/net/bonding/bond_debugfs.c | 5 -
drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c | 107 ++++---------
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 -
.../net/ethernet/broadcom/bnxt/bnxt_debugfs.c | 39 ++---
.../ethernet/chelsio/cxgb4/cxgb4_debugfs.c | 5 +-
.../net/ethernet/chelsio/cxgb4/cxgb4_main.c | 3 -
.../ethernet/chelsio/cxgb4vf/cxgb4vf_main.c | 21 +--
.../freescale/dpaa2/dpaa2-eth-debugfs.c | 54 +------
.../freescale/dpaa2/dpaa2-eth-debugfs.h | 3 -
.../ethernet/hisilicon/hns3/hns3_debugfs.c | 17 +-
.../net/ethernet/intel/fm10k/fm10k_debugfs.c | 2 -
.../net/ethernet/intel/i40e/i40e_debugfs.c | 22 +--
.../net/ethernet/intel/ixgbe/ixgbe_debugfs.c | 22 +--
.../ethernet/marvell/mvpp2/mvpp2_debugfs.c | 19 +--
drivers/net/ethernet/marvell/skge.c | 39 ++---
drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 51 +-----
.../net/ethernet/mellanox/mlx5/core/debugfs.c | 102 ++----------
drivers/net/ethernet/mellanox/mlx5/core/eq.c | 11 +-
.../net/ethernet/mellanox/mlx5/core/lib/eq.h | 2 +-
.../net/ethernet/mellanox/mlx5/core/main.c | 7 +-
.../ethernet/mellanox/mlx5/core/mlx5_core.h | 2 +-
.../ethernet/netronome/nfp/nfp_net_debugfs.c | 17 +-
drivers/net/ethernet/qualcomm/qca_debug.c | 13 +-
drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 -
.../net/ethernet/stmicro/stmmac/stmmac_main.c | 52 +-----
drivers/net/ieee802154/adf7242.c | 13 +-
drivers/net/ieee802154/at86rf230.c | 20 +--
drivers/net/ieee802154/ca8210.c | 9 +-
drivers/net/wimax/i2400m/debugfs.c | 150 +++---------------
drivers/net/wimax/i2400m/driver.c | 7 +-
drivers/net/wimax/i2400m/i2400m.h | 7 +-
drivers/net/wimax/i2400m/usb.c | 64 ++------
include/linux/mlx5/driver.h | 12 +-
include/linux/wimax/debug.h | 20 +--
net/wimax/debugfs.c | 42 +----
net/wimax/stack.c | 11 +-
net/wimax/wimax-internal.h | 7 +-
37 files changed, 175 insertions(+), 805 deletions(-)
--
2.22.0
next reply other threads:[~2019-08-10 10:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-10 10:17 Greg Kroah-Hartman [this message]
2019-08-10 10:17 ` [PATCH v3 01/17] wimax: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-08-10 10:17 ` [PATCH v3 02/17] bonding: no need to print a message if debugfs_create_dir() fails Greg Kroah-Hartman
2019-08-10 10:17 ` [PATCH v3 03/17] mlx5: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-08-10 10:17 ` [PATCH v3 04/17] xgbe: " Greg Kroah-Hartman
2019-08-10 10:17 ` [PATCH v3 05/17] bnxt: " Greg Kroah-Hartman
2019-08-10 10:17 ` [PATCH v3 06/17] cxgb4: " Greg Kroah-Hartman
2019-08-10 10:17 ` [PATCH v3 07/17] hns3: " Greg Kroah-Hartman
2019-08-10 10:17 ` [PATCH v3 08/17] nfp: " Greg Kroah-Hartman
2019-08-10 10:17 ` [PATCH v3 09/17] stmmac: " Greg Kroah-Hartman
2019-08-10 10:17 ` [PATCH v3 10/17] dpaa2: " Greg Kroah-Hartman
2019-08-10 10:17 ` [PATCH v3 11/17] qca: " Greg Kroah-Hartman
2019-08-13 9:21 ` Stefan Wahren
2019-08-10 10:17 ` [PATCH v3 12/17] skge: " Greg Kroah-Hartman
2019-08-10 10:17 ` [PATCH v3 13/17] mvpp2: " Greg Kroah-Hartman
2019-08-12 17:55 ` Nick Desaulniers
2019-08-12 19:01 ` Greg Kroah-Hartman
2019-08-12 19:44 ` Nick Desaulniers
2019-08-12 19:51 ` Greg Kroah-Hartman
2019-08-10 10:17 ` [PATCH v3 14/17] fm10k: " Greg Kroah-Hartman
2019-08-12 15:46 ` Jeff Kirsher
2019-08-10 10:17 ` [PATCH v3 15/17] i40e: " Greg Kroah-Hartman
2019-08-12 15:48 ` Jeff Kirsher
2019-08-10 10:17 ` [PATCH v3 16/17] ixgbe: " Greg Kroah-Hartman
2019-08-12 15:49 ` Jeff Kirsher
2019-08-10 10:17 ` [PATCH v3 17/17] ieee802154: " Greg Kroah-Hartman
2019-08-10 22:26 ` [PATCH v3 00/17] Networking driver debugfs cleanups David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190810101732.26612-1-gregkh@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).