From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28B00C32751 for ; Sat, 10 Aug 2019 10:17:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F149320B7C for ; Sat, 10 Aug 2019 10:17:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565432263; bh=FXzKFI3aBZftc8tGfTM9CLI3kJFHhadi4miXcAcjqhc=; h=From:To:Cc:Subject:Date:List-ID:From; b=h8jBPAy2E/QZo6DZAec8DQf6lMHnZaDDgWg8Erh1YR/kSXnzaSYUbLgJBciy8jtH/ lGtOasi06kQvypx2f+LCwL7DEHKMY1PbqpbqpvRX7Tsz7GXg5XNxCZv5EGoE0i1RGR XsAQeZpSX5ULM5MHcBfE3NyQp0Vc9M8IZVuTDbHI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726154AbfHJKRl (ORCPT ); Sat, 10 Aug 2019 06:17:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:57660 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725497AbfHJKRl (ORCPT ); Sat, 10 Aug 2019 06:17:41 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 93DDC20B7C; Sat, 10 Aug 2019 10:17:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565432260; bh=FXzKFI3aBZftc8tGfTM9CLI3kJFHhadi4miXcAcjqhc=; h=From:To:Cc:Subject:Date:From; b=sew2Czdbl9yU2X1BsXjoyf9SNjpLQvGsd5r4dxm8vwOzvH9p5mw8qVN7RfZsa3w3q gowJOy42m44Ewd3Lb+c6eACwlJnU4TlE01azkf7S4imIvOTkvJPlbMCx2wY47q+4f8 AWByYtL8qKM+vS2ydtQwDnV93JNJZTgymZd8cAYM= From: Greg Kroah-Hartman To: netdev@vger.kernel.org Cc: Greg Kroah-Hartman Subject: [PATCH v3 00/17] Networking driver debugfs cleanups Date: Sat, 10 Aug 2019 12:17:15 +0200 Message-Id: <20190810101732.26612-1-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org There is no need to test the result of any debugfs call anymore. The debugfs core warns the user if something fails, and the return value of a debugfs call can always be fed back into another debugfs call with no problems. Also, debugfs is for debugging, so if there are problems with debugfs (i.e. the system is out of memory) the rest of the kernel should not change behavior, so testing for debugfs calls is pointless and not the goal of debugfs at all. This series cleans up a lot of networking drivers and some wimax code that was calling debugfs and trying to do something with the return value that it didn't need to. Removing this logic makes the code smaller, easier to understand, and use less run-time memory in some cases, all good things. The series is against net-next, and have no dependancies between any of them if they want to go through any random tree/order. Or, if wanted, I can take them through my driver-core tree where other debugfs cleanups are being slowly fed during major merge windows. thanks, greg k-h v3: fix build warning in i2400m, I thought I had caught them all :( add acks from some reviewers v2: fix up build warnings, it's as if I never even built these. Ugh, so sorry for wasting people's time with the v1 series. I need to stop relying on 0-day as it isn't working well anymore :( Greg Kroah-Hartman (17): wimax: no need to check return value of debugfs_create functions bonding: no need to print a message if debugfs_create_dir() fails mlx5: no need to check return value of debugfs_create functions xgbe: no need to check return value of debugfs_create functions bnxt: no need to check return value of debugfs_create functions cxgb4: no need to check return value of debugfs_create functions hns3: no need to check return value of debugfs_create functions nfp: no need to check return value of debugfs_create functions stmmac: no need to check return value of debugfs_create functions dpaa2: no need to check return value of debugfs_create functions qca: no need to check return value of debugfs_create functions skge: no need to check return value of debugfs_create functions mvpp2: no need to check return value of debugfs_create functions fm10k: no need to check return value of debugfs_create functions i40e: no need to check return value of debugfs_create functions ixgbe: no need to check return value of debugfs_create functions ieee802154: no need to check return value of debugfs_create functions drivers/net/bonding/bond_debugfs.c | 5 - drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c | 107 ++++--------- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 - .../net/ethernet/broadcom/bnxt/bnxt_debugfs.c | 39 ++--- .../ethernet/chelsio/cxgb4/cxgb4_debugfs.c | 5 +- .../net/ethernet/chelsio/cxgb4/cxgb4_main.c | 3 - .../ethernet/chelsio/cxgb4vf/cxgb4vf_main.c | 21 +-- .../freescale/dpaa2/dpaa2-eth-debugfs.c | 54 +------ .../freescale/dpaa2/dpaa2-eth-debugfs.h | 3 - .../ethernet/hisilicon/hns3/hns3_debugfs.c | 17 +- .../net/ethernet/intel/fm10k/fm10k_debugfs.c | 2 - .../net/ethernet/intel/i40e/i40e_debugfs.c | 22 +-- .../net/ethernet/intel/ixgbe/ixgbe_debugfs.c | 22 +-- .../ethernet/marvell/mvpp2/mvpp2_debugfs.c | 19 +-- drivers/net/ethernet/marvell/skge.c | 39 ++--- drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 51 +----- .../net/ethernet/mellanox/mlx5/core/debugfs.c | 102 ++---------- drivers/net/ethernet/mellanox/mlx5/core/eq.c | 11 +- .../net/ethernet/mellanox/mlx5/core/lib/eq.h | 2 +- .../net/ethernet/mellanox/mlx5/core/main.c | 7 +- .../ethernet/mellanox/mlx5/core/mlx5_core.h | 2 +- .../ethernet/netronome/nfp/nfp_net_debugfs.c | 17 +- drivers/net/ethernet/qualcomm/qca_debug.c | 13 +- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 - .../net/ethernet/stmicro/stmmac/stmmac_main.c | 52 +----- drivers/net/ieee802154/adf7242.c | 13 +- drivers/net/ieee802154/at86rf230.c | 20 +-- drivers/net/ieee802154/ca8210.c | 9 +- drivers/net/wimax/i2400m/debugfs.c | 150 +++--------------- drivers/net/wimax/i2400m/driver.c | 7 +- drivers/net/wimax/i2400m/i2400m.h | 7 +- drivers/net/wimax/i2400m/usb.c | 64 ++------ include/linux/mlx5/driver.h | 12 +- include/linux/wimax/debug.h | 20 +-- net/wimax/debugfs.c | 42 +---- net/wimax/stack.c | 11 +- net/wimax/wimax-internal.h | 7 +- 37 files changed, 175 insertions(+), 805 deletions(-) -- 2.22.0