From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A560C32751 for ; Sat, 10 Aug 2019 10:18:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 21A4F217D7 for ; Sat, 10 Aug 2019 10:18:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565432289; bh=RUsQEza+Ar9N+FJo3L6rYdD5QR6fkUA8bSv2nnoRzf0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=dW04tw/paPQADepAYS8QIgKYFl+M1X5idnadWFgsZaJ0HqP7HFIpnz38BVRf2ZE+5 6DcnPaN94e5MJiNSu+YVtPFRW8LoRcNM/f5HAC1VEHotxPIpH/fXUPD3Gbnqr1PDTV AGHy9Sx4MzJPI5hM0gP0825kUYU5DmhnyIp0X/2k= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726368AbfHJKSI (ORCPT ); Sat, 10 Aug 2019 06:18:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:57940 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725497AbfHJKSH (ORCPT ); Sat, 10 Aug 2019 06:18:07 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9FF50217D7; Sat, 10 Aug 2019 10:18:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565432286; bh=RUsQEza+Ar9N+FJo3L6rYdD5QR6fkUA8bSv2nnoRzf0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NRaA2Z6XyED4r71Ba8z8/tVah+Mg48gyUGb+3cs08gBYaoCtI1akSYDiCK/ZId+8c z5LtcjLnlV4h2+Ic+infze9fJ0X4yJxIvCPLxDAf8+JeyUsTqUARdgQ1/IwwfYSkj+ TLgQ0MtKn+YdLfgBActiIJWupzAbm+/V2MvcJIng= From: Greg Kroah-Hartman To: netdev@vger.kernel.org Cc: Greg Kroah-Hartman , Jay Vosburgh , Veaceslav Falico , Andy Gospodarek , "David S. Miller" Subject: [PATCH v3 02/17] bonding: no need to print a message if debugfs_create_dir() fails Date: Sat, 10 Aug 2019 12:17:17 +0200 Message-Id: <20190810101732.26612-3-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190810101732.26612-1-gregkh@linuxfoundation.org> References: <20190810101732.26612-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The debugfs core now will print a message if this function fails, so don't duplicate that logic. Also, no need to change the code logic if the call fails either, as no debugfs calls should interrupt normal kernel code for any reason. Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/net/bonding/bond_debugfs.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/bonding/bond_debugfs.c b/drivers/net/bonding/bond_debugfs.c index 1360f1ffe070..f3f86ef68ae0 100644 --- a/drivers/net/bonding/bond_debugfs.c +++ b/drivers/net/bonding/bond_debugfs.c @@ -55,11 +55,6 @@ void bond_debug_register(struct bonding *bond) bond->debug_dir = debugfs_create_dir(bond->dev->name, bonding_debug_root); - if (!bond->debug_dir) { - netdev_warn(bond->dev, "failed to register to debugfs\n"); - return; - } - debugfs_create_file("rlb_hash_table", 0400, bond->debug_dir, bond, &bond_debug_rlb_hash_fops); } -- 2.22.0