From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47031C433FF for ; Mon, 12 Aug 2019 04:02:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1B6E120842 for ; Mon, 12 Aug 2019 04:02:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725843AbfHLECU (ORCPT ); Mon, 12 Aug 2019 00:02:20 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:38256 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725648AbfHLECT (ORCPT ); Mon, 12 Aug 2019 00:02:19 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 2F826133F323A; Sun, 11 Aug 2019 21:02:19 -0700 (PDT) Date: Sun, 11 Aug 2019 21:02:18 -0700 (PDT) Message-Id: <20190811.210218.1719186095860421886.davem@davemloft.net> To: dsahern@kernel.org Cc: netdev@vger.kernel.org, jiri@resnulli.us, dsahern@gmail.com Subject: Re: [PATCH net] netdevsim: Restore per-network namespace accounting for fib entries From: David Miller In-Reply-To: <20190806191517.8713-1-dsahern@kernel.org> References: <20190806191517.8713-1-dsahern@kernel.org> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 11 Aug 2019 21:02:19 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: David Ahern Date: Tue, 6 Aug 2019 12:15:17 -0700 > From: David Ahern > > Prior to the commit in the fixes tag, the resource controller in netdevsim > tracked fib entries and rules per network namespace. Restore that behavior. > > Fixes: 5fc494225c1e ("netdevsim: create devlink instance per netdevsim instance") > Signed-off-by: David Ahern Applied, thanks for bringing this to our attention and fixing it David. Jiri, I disagree you on every single possible level. If you didn't like how netdevsim worked in this area the opportunity to do something about it was way back when it went in. No matter how completely busted or disagreeable an interface is, once we have committed it to a release (and in particular people are knowingly using and depending upon it) you cannot break it. It doesn't matter how much you disagree with something, you cannot break it when it's out there and actively in use. Do you have any idea how much stuff I'd like to break because I think the design turned out to be completely wrong? But I can't.