From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AF45C433FF for ; Sun, 11 Aug 2019 10:49:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CEC9020842 for ; Sun, 11 Aug 2019 10:49:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565520569; bh=iMnOh61NN2ANHUUWGW6ZcwhP5QFtijWXY4bh9bfUeOw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=cZgyHG6O0LSEM1MXUOVFwobjHk9WQH7x+xcWMJon9WfhKPWiN1YPbqrT9Y5PveHTj GBmy5r7tvrKSDnmBxQDkikWBHkHVymLyCJlesM10KHwy/iNvWGUcAkmVkmJHrzzMcp mtRECfdHaLeaYVEtkSE2IZ2AaKACqR0AidX8oVvM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725826AbfHKKt2 (ORCPT ); Sun, 11 Aug 2019 06:49:28 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:36963 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725813AbfHKKt2 (ORCPT ); Sun, 11 Aug 2019 06:49:28 -0400 Received: by mail-wr1-f65.google.com with SMTP id z11so162268wrt.4 for ; Sun, 11 Aug 2019 03:49:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=E78SJ0Wx+p4WUVJGdn+lRCXRUxyY8ZQuys3hsU4+Pbg=; b=fyTp7cdcTGEY/z6qmXwILd8MJX5L4bFJzoNqv+qOBN0+E2tbdS6kM1zWHGEc+WMFTP x6LnAwTSmYE79vPTGyf5wOz52EkpjQTdMCuo50dULM8KYV7n2CNaJys9x6xynleRhQqi QynovTHwQ0vW5CGKUsL+6LbKpOEtYt5slqK9Qvhh258qDDR8xMdMXgvEYbp5M+FAkCzR EFZP9mbuIhDEV7lwAdrquGIC1/zjt3frNc/H4ASJ5rkQmKv+MGJSijUSC7Meu/ixMY6q qSPhWSEWXaj2Yl6Luupzj6MoaO4oua/OyfarhHEBHOFRmBTenislhnzTdsqlsxr6X89T QBcQ== X-Gm-Message-State: APjAAAWmvXDMRSQdWm7FvteBTPXTWdr5r/4G0aE7g18M+QSeXbaZNHa3 HnYH8mQXwn1mEl8B4JELJK6tZnYY X-Google-Smtp-Source: APXvYqxSd3h8oHTz6LvtrAtCZl19KIOdEFPI4jkugfz47+BbK2BmVbqu5GEJgHTg0ekVKP29z/vRQQ== X-Received: by 2002:adf:fcd1:: with SMTP id f17mr22060436wrs.252.1565520566919; Sun, 11 Aug 2019 03:49:26 -0700 (PDT) Received: from debian (30.163.200.146.dyn.plus.net. [146.200.163.30]) by smtp.gmail.com with ESMTPSA id 25sm10037491wmi.40.2019.08.11.03.49.26 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sun, 11 Aug 2019 03:49:26 -0700 (PDT) Date: Sun, 11 Aug 2019 11:49:24 +0100 From: Wei Liu To: Greg Kroah-Hartman Cc: Wei Liu , Paul Durrant , xen-devel@lists.xenproject.org, netdev@vger.kernel.org Subject: Re: [PATCH] xen-netback: no need to check return value of debugfs_create functions Message-ID: <20190811104924.kzso22ke7jagjvyj@debian> References: <20190810103108.GA29487@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190810103108.GA29487@kroah.com> User-Agent: NeoMutt/20180716 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Aug 10, 2019 at 12:31:08PM +0200, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Wei Liu > Cc: Paul Durrant > Cc: xen-devel@lists.xenproject.org > Cc: netdev@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman Acked-by: Wei Liu