From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFE33C433FF for ; Sun, 11 Aug 2019 15:40:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 922E32085B for ; Sun, 11 Aug 2019 15:40:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="xX1kmb1F" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726516AbfHKPkG (ORCPT ); Sun, 11 Aug 2019 11:40:06 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:51224 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726424AbfHKPkG (ORCPT ); Sun, 11 Aug 2019 11:40:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=8ozBoqtYYvBTfGwvlCc0YKD6CWnEH6JBg0zCA/A1o78=; b=xX1kmb1Fza1kvfDtj+3d2dZCTr itkMDemvsldy/dV50rtbp8uIxtDHwNCeLk3j1Bhb8z9DdhtPpmp/2z6RVNPjhmJXcXTRdIldU9IGA 6TRF0kiiGKxLK5qyvS6m5YYDeiW/n+ndujRYS2UPoNNfdt+x2/ljpjozVO7yVwOEgVL8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hwpwv-0003vB-Fz; Sun, 11 Aug 2019 17:40:01 +0200 Date: Sun, 11 Aug 2019 17:40:01 +0200 From: Andrew Lunn To: Marek =?iso-8859-1?Q?Beh=FAn?= Cc: netdev@vger.kernel.org, Heiner Kallweit , Sebastian Reichel , Vivien Didelot , Florian Fainelli , "David S . Miller" Subject: Re: [PATCH net-next 2/2] net: fixed_phy: set is_gigabit_capable member when needed Message-ID: <20190811154001.GC14290@lunn.ch> References: <20190811150812.6780-1-marek.behun@nic.cz> <20190811150812.6780-2-marek.behun@nic.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190811150812.6780-2-marek.behun@nic.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Aug 11, 2019 at 05:08:12PM +0200, Marek Behún wrote: > The fixed_phy driver does not set the phydev->is_gigabit_capable member > when the fixed_phy is gigabit capable. Neither does any other PHY driver. It should be possible to tell if a PHY supports 1G by looking at register values. If this does not work for fixed_link, it means we are missing something in the emulation. That is what we should be fixing. Also, this change has nothing to do the lp_advertise, what you previously said the problem was. At the moment, i don't get the feeling you have really dug all the way down and really understand the root causes. Andrew