From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67A3FC433FF for ; Sun, 11 Aug 2019 16:08:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 25DCD20880 for ; Sun, 11 Aug 2019 16:08:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=nic.cz header.i=@nic.cz header.b="b08v0LY3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726525AbfHKQIS (ORCPT ); Sun, 11 Aug 2019 12:08:18 -0400 Received: from mail.nic.cz ([217.31.204.67]:50700 "EHLO mail.nic.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726014AbfHKQIR (ORCPT ); Sun, 11 Aug 2019 12:08:17 -0400 Received: from localhost (unknown [172.20.6.135]) by mail.nic.cz (Postfix) with ESMTPSA id E4734140B17; Sun, 11 Aug 2019 18:08:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1565539696; bh=ROGZS0WEgXXpqMSTzhVir73G0XwTaeLH1ABEdZBEk0I=; h=Date:From:To; b=b08v0LY3FElel2xKPcSAfo/doE4WKH/RC8aYQfe4cwPoCCNhNBzwbBZVBqIdHokdZ jvZKeY65Qj8coCsa5+eQFWOvJ+BwMNSTcEtwsnpsiVYen0wuF9DppMQhUaKZIGllSU TURD9C6XJoQSs8P9UaFHPzC2iKM7hCRUP21uLPL8= Date: Sun, 11 Aug 2019 18:08:15 +0200 From: Marek Behun To: Andrew Lunn Cc: netdev@vger.kernel.org, Heiner Kallweit , Sebastian Reichel , Vivien Didelot , Florian Fainelli , "David S . Miller" Subject: Re: [PATCH net-next 2/2] net: fixed_phy: set is_gigabit_capable member when needed Message-ID: <20190811180815.024870da@nic.cz> In-Reply-To: <20190811154001.GC14290@lunn.ch> References: <20190811150812.6780-1-marek.behun@nic.cz> <20190811150812.6780-2-marek.behun@nic.cz> <20190811154001.GC14290@lunn.ch> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Virus-Scanned: clamav-milter 0.100.3 at mail.nic.cz X-Virus-Status: Clean Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, 11 Aug 2019 17:40:01 +0200 Andrew Lunn wrote: > On Sun, Aug 11, 2019 at 05:08:12PM +0200, Marek Beh=C3=BAn wrote: > > The fixed_phy driver does not set the phydev->is_gigabit_capable member > > when the fixed_phy is gigabit capable. =20 >=20 > Neither does any other PHY driver. It should be possible to tell if a > PHY supports 1G by looking at register values. If this does not work > for fixed_link, it means we are missing something in the emulation. > That is what we should be fixing. >=20 > Also, this change has nothing to do the lp_advertise, what you > previously said the problem was. At the moment, i don't get the > feeling you have really dug all the way down and really understand the > root causes. >=20 > Andrew Andrew, is_gigabit_capable is otherwise set only in the phy_probe function. This function is not called at all for the DSA cpu port fixed_link phy. Why is that? But I guess it is not important anymore, if CPU and DSA were converted to phylink in net-next. I shall test it and let you know. In any case, sorry for the spam. Marek