From: David Miller <davem@davemloft.net>
To: git@andred.net
Cc: linux-kernel@vger.kernel.org, andrew@lunn.ch,
f.fainelli@gmail.com, hkallweit1@gmail.com,
netdev@vger.kernel.org
Subject: Re: [PATCH v2] net: phy: at803x: stop switching phy delay config needlessly
Date: Mon, 12 Aug 2019 14:02:44 -0700 (PDT) [thread overview]
Message-ID: <20190812.140244.1191094093267734606.davem@davemloft.net> (raw)
In-Reply-To: <20190809112025.27482-1-git@andred.net>
From: André Draszik <git@andred.net>
Date: Fri, 9 Aug 2019 12:20:25 +0100
> This driver does a funny dance disabling and re-enabling
> RX and/or TX delays. In any of the RGMII-ID modes, it first
> disables the delays, just to re-enable them again right
> away. This looks like a needless exercise.
>
> Just enable the respective delays when in any of the
> relevant 'id' modes, and disable them otherwise.
>
> Also, remove comments which don't add anything that can't be
> seen by looking at the code.
>
> Signed-off-by: André Draszik <git@andred.net>
Applied.
prev parent reply other threads:[~2019-08-12 21:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 0:57 [PATCH] net: phy: at803x: stop switching phy delay config needlessly André Draszik
2019-08-09 9:43 ` Vladimir Oltean
2019-08-09 10:00 ` André Draszik
2019-08-09 11:09 ` Vladimir Oltean
2019-08-09 11:15 ` André Draszik
2019-08-09 11:20 ` [PATCH v2] " André Draszik
2019-08-12 21:02 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190812.140244.1191094093267734606.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=git@andred.net \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).