From: Florian Westphal <fw@strlen.de>
To: Todd Seidelmann <tseidelmann@linode.com>
Cc: netdev@vger.kernel.org,
netfilter-devel <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH net] netfilter: ebtables: Fix argument order to ADD_COUNTER
Date: Mon, 12 Aug 2019 23:25:45 +0200 [thread overview]
Message-ID: <20190812212545.le2m7vsihcyk7ti6@breakpoint.cc> (raw)
In-Reply-To: <00a6c489-dc5b-d66f-f06d-b8785acb50e7@linode.com>
Todd Seidelmann <tseidelmann@linode.com> wrote:
> The ordering of arguments to the x_tables ADD_COUNTER macro
> appears to be wrong in ebtables (cf. ip_tables.c, ip6_tables.c,
> and arp_tables.c).
>
> This causes data corruption in the ebtables userspace tools
> because they get incorrect packet & byte counts from the kernel.
Please send netfilter patches to netfilter-devel@vger.kernel.org .
Fixes: d72133e628803 ("netfilter: ebtables: use ADD_COUNTER macro")
Acked-by: Florian Westphal <fw@strlen.de>
prev parent reply other threads:[~2019-08-12 21:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 21:20 [PATCH net] netfilter: ebtables: Fix argument order to ADD_COUNTER Todd Seidelmann
2019-08-12 21:25 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190812212545.le2m7vsihcyk7ti6@breakpoint.cc \
--to=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=tseidelmann@linode.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox