From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9398FC0650F for ; Wed, 14 Aug 2019 03:53:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 657782083B for ; Wed, 14 Aug 2019 03:53:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="l8Xo7WQo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727119AbfHNDxo (ORCPT ); Tue, 13 Aug 2019 23:53:44 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:45353 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726739AbfHNDxo (ORCPT ); Tue, 13 Aug 2019 23:53:44 -0400 Received: by mail-pg1-f193.google.com with SMTP id o13so52357105pgp.12 for ; Tue, 13 Aug 2019 20:53:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=3PVbz4fA9KpLPcvGNgBvcsVU8TB7xIMJ9/o12n3NZ0M=; b=l8Xo7WQo6K5GXdcRM9U3Xiyy7kBwrOUNfdmx4iYaYLKNtpcFw9JYF1J+amhVp3Hl0x jLQ1HtklcSGZjFGEG3Xn33cmvybIqS+1EdlB93giH7qd1np+RceVBjI4KoiYq56LA1nt flYr1HydS+JSk/Fyco0rLNRRXumiXnfT7EI0gFjTtZpyD3VO4xdDiSGy3pp9O0L8l5uo CvJgtuA0FsUDlHYX+RdMlEkrxCaOC1wmgObIUm+8TAETe8CGTv985lXk/dIYsur9/Ki7 Qu8ZIX2PD3fGdJ4evBk26i489toylixcQAiOnNXRrbUg9c9jGIqR+mJqWBpykUS0fcN7 GADg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=3PVbz4fA9KpLPcvGNgBvcsVU8TB7xIMJ9/o12n3NZ0M=; b=AUvEr6vuE8WxFES5Qv3bS0g20dqDQUgWnimDd+22IULgvoDKPyaifJw2BodsuYbDdw EHl2Jxx1FGrCPdhugA753b7en+utpZDO2nQiIDpJMOwwsShG5vWayc+4HHHX1Xqa5EDC goF4fCNOUXrXAGjZq28tyhafOEh7pi0YtmAETsNBhrdFVu1Nk0/F+XKlMay1bBEcqPL6 fhnxo2BeMyupQcqRmm7H6FWvGMwkM67167xHMLvK+J7p1i9eX0eP3JbCk5E0tgAfVS+8 2iUUrUfWV6hMmmgz3lzCQgfdZk0glnFgKydGrvXTNCjmT1gNy39MSMwqyf6rHsc1xDPl 6a4g== X-Gm-Message-State: APjAAAXR6vo3/FZ7D/47EcvbnMBgll8ccN7SeiesXS7/alGioDb+no/m AYgxvV4jHHxXXZbMvescq0G5lg== X-Google-Smtp-Source: APXvYqzgCJbjZpnm+0rUggHh9cJA55VDGC1Pk66fgdqme9/763gsl0rfXMBx6lq7t/sPlRDY287P7Q== X-Received: by 2002:a65:430a:: with SMTP id j10mr38313274pgq.374.1565754823394; Tue, 13 Aug 2019 20:53:43 -0700 (PDT) Received: from cakuba.netronome.com (c-71-204-185-212.hsd1.ca.comcast.net. [71.204.185.212]) by smtp.gmail.com with ESMTPSA id 22sm51104343pgl.0.2019.08.13.20.53.42 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 13 Aug 2019 20:53:43 -0700 (PDT) Date: Tue, 13 Aug 2019 20:53:32 -0700 From: Jakub Kicinski To: zhengbin Cc: , , , , , , Subject: Re: [PATCH] sctp: fix memleak in sctp_send_reset_streams Message-ID: <20190813205332.60b50d8b@cakuba.netronome.com> In-Reply-To: <1565705150-17242-1-git-send-email-zhengbin13@huawei.com> References: <1565705150-17242-1-git-send-email-zhengbin13@huawei.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 13 Aug 2019 22:05:50 +0800, zhengbin wrote: > If the stream outq is not empty, need to kfree nstr_list. > > Fixes: d570a59c5b5f ("sctp: only allow the out stream reset when the stream outq is empty") > Reported-by: Hulk Robot > Signed-off-by: zhengbin Applied, thank you!