From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91A37C433FF for ; Tue, 13 Aug 2019 20:45:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4600320665 for ; Tue, 13 Aug 2019 20:45:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=nic.cz header.i=@nic.cz header.b="r1AfBDs+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726188AbfHMUpF (ORCPT ); Tue, 13 Aug 2019 16:45:05 -0400 Received: from mail.nic.cz ([217.31.204.67]:49050 "EHLO mail.nic.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726007AbfHMUpF (ORCPT ); Tue, 13 Aug 2019 16:45:05 -0400 Received: from localhost (unknown [172.20.6.135]) by mail.nic.cz (Postfix) with ESMTPSA id 74FD8140C54; Tue, 13 Aug 2019 22:45:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1565729103; bh=xlg+VDxUwopGuCsrQrjcS7+TKSmPoCBEYspk4L9l9bs=; h=Date:From:To; b=r1AfBDs+sVnWnAcvqA6NctP7v+W/kOxtF2zrd1xa/UVreazG/c9Ar2XlUGUDFoI12 bZKS8c1Xd4Ef6PFOB4LXhS6l0IiwnvbDpCNDyuwYIiT2ZioSv+yJ+ZSvdWZkHepcVN cjw63MmpCKcNCz/lcPYYRegXQ6WAX+T3CF33JYPc= Date: Tue, 13 Aug 2019 22:45:02 +0200 From: Marek Behun To: Andrew Lunn Cc: netdev@vger.kernel.org, Vivien Didelot , Heiner Kallweit Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: check for mode change in port_setup_mac Message-ID: <20190813224502.5a083d77@nic.cz> In-Reply-To: <20190813203234.GO15047@lunn.ch> References: <20190813171243.27898-1-marek.behun@nic.cz> <20190813203234.GO15047@lunn.ch> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Virus-Scanned: clamav-milter 0.100.3 at mail.nic.cz X-Virus-Status: Clean Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 13 Aug 2019 22:32:34 +0200 Andrew Lunn wrote: > On Tue, Aug 13, 2019 at 07:12:43PM +0200, Marek Beh=C3=BAn wrote: > > @@ -598,12 +599,49 @@ int mv88e6352_port_link_state(struct mv88e6xxx_ch= ip *chip, int port, > > struct phylink_link_state *state) > > { > > int err; > > - u16 reg; > > + u16 reg, mac; > > =20 > > err =3D mv88e6xxx_port_read(chip, port, MV88E6XXX_PORT_STS, ®); > > if (err) > > return err; >=20 > Hi Marek >=20 > It seems a bit off putting this block of code here, after reading > MV88E6XXX_PORT_STS but before using the value. You don't need STS to > determine the interface mode. >=20 > If you keep the code together, you can then reuse reg, rather than add > mac. >=20 > Apart from that, this looks O.K. >=20 > Andrew Hi Andrew, you are right, I shall rewrite this. Thank you. Marek