Re: [PATCH net-next v2 11/14] netdevsim: Add devlink-trap support

[Ido Schimmel <idosch@idosch.org>]

On Wed, Aug 14, 2019 at 04:59:57PM -0700, Jakub Kicinski wrote:
> On Tue, 13 Aug 2019 10:53:57 +0300, Ido Schimmel wrote:
> > diff --git a/drivers/net/netdevsim/dev.c b/drivers/net/netdevsim/dev.c
> > index 08ca59fc189b..2758d95c8d18 100644
> > --- a/drivers/net/netdevsim/dev.c
> > +++ b/drivers/net/netdevsim/dev.c
> > @@ -17,11 +17,21 @@
> >  
> >  #include <linux/debugfs.h>
> >  #include <linux/device.h>
> > +#include <linux/etherdevice.h>
> > +#include <linux/inet.h>
> > +#include <linux/jiffies.h>
> > +#include <linux/kernel.h>
> >  #include <linux/list.h>
> >  #include <linux/mutex.h>
> >  #include <linux/random.h>
> > +#include <linux/workqueue.h>
> > +#include <linux/random.h>
> >  #include <linux/rtnetlink.h>
> >  #include <net/devlink.h>
> > +#include <net/ip.h>
> > +#include <uapi/linux/devlink.h>
> > +#include <uapi/linux/ip.h>
> > +#include <uapi/linux/udp.h>
> 
> Please keep includes ordered alphabetically. You're adding
> linux/random.h second time.

Will fix.

> 
> >  #include "netdevsim.h"
> 
> > +static void nsim_dev_trap_report(struct nsim_dev_port *nsim_dev_port)
> > +{
> > +	struct nsim_dev *nsim_dev = nsim_dev_port->ns->nsim_dev;
> > +	struct nsim_trap_data *nsim_trap_data = nsim_dev->trap_data;
> > +	struct devlink *devlink = priv_to_devlink(nsim_dev);
> > +	int i;
> 
> reverse christmas tree, please

Likewise.

Thanks!