From: Ido Schimmel <idosch@idosch.org>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
nhorman@tuxdriver.com, jiri@mellanox.com, toke@redhat.com,
dsahern@gmail.com, roopa@cumulusnetworks.com,
nikolay@cumulusnetworks.com, andy@greyhouse.net,
f.fainelli@gmail.com, andrew@lunn.ch, vivien.didelot@gmail.com,
mlxsw@mellanox.com, Ido Schimmel <idosch@mellanox.com>
Subject: Re: [PATCH net-next v2 13/14] selftests: devlink_trap: Add test cases for devlink-trap
Date: Thu, 15 Aug 2019 09:34:05 +0300 [thread overview]
Message-ID: <20190815063405.GB12222@splinter> (raw)
In-Reply-To: <20190814174229.1ab4fd1b@cakuba.netronome.com>
On Wed, Aug 14, 2019 at 05:42:29PM -0700, Jakub Kicinski wrote:
> On Tue, 13 Aug 2019 10:53:59 +0300, Ido Schimmel wrote:
> > From: Ido Schimmel <idosch@mellanox.com>
> >
> > Add test cases for devlink-trap on top of the netdevsim implementation.
> >
> > The tests focus on the devlink-trap core infrastructure and user space
> > API. They test both good and bad flows and also dismantle of the netdev
> > and devlink device used to report trapped packets.
> >
> > This allows device drivers to focus their tests on device-specific
> > functionality.
> >
> > Signed-off-by: Ido Schimmel <idosch@mellanox.com>
> > Acked-by: Jiri Pirko <jiri@mellanox.com>
>
> Thanks for the test!
>
> Should it perhaps live in:
> tools/testing/selftests/drivers/net/netdevsim/
> ?
>
> That's where Jiri puts his devlink tests..
Yea, good point. Will move it there.
>
> Also the test seems to require netdevsim to be loaded, otherwise:
> # ./devlink_trap.sh
> SKIP: No netdevsim support
>
> Is that expected?
No, my bad. I need to change the check to see if netdevsim is loaded and
otherwise load the module.
Thanks!
next prev parent reply other threads:[~2019-08-15 6:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 7:53 [PATCH net-next v2 00/14] Add drop monitor for offloaded data paths Ido Schimmel
2019-08-13 7:53 ` [PATCH net-next v2 01/14] drop_monitor: Move per-CPU data init/fini to separate functions Ido Schimmel
2019-08-13 7:53 ` [PATCH net-next v2 02/14] drop_monitor: Initialize hardware per-CPU data Ido Schimmel
2019-08-13 7:53 ` [PATCH net-next v2 03/14] drop_monitor: Add basic infrastructure for hardware drops Ido Schimmel
2019-08-13 7:53 ` [PATCH net-next v2 04/14] drop_monitor: Consider all monitoring states before performing configuration Ido Schimmel
2019-08-13 7:53 ` [PATCH net-next v2 05/14] drop_monitor: Add support for packet alert mode for hardware drops Ido Schimmel
2019-08-13 7:53 ` [PATCH net-next v2 06/14] drop_monitor: Add support for summary " Ido Schimmel
2019-08-13 7:53 ` [PATCH net-next v2 07/14] drop_monitor: Allow user to start monitoring " Ido Schimmel
2019-08-13 7:53 ` [PATCH net-next v2 08/14] devlink: Add packet trap infrastructure Ido Schimmel
2019-08-13 7:53 ` [PATCH net-next v2 09/14] devlink: Add generic packet traps and groups Ido Schimmel
2019-08-13 7:53 ` [PATCH net-next v2 10/14] Documentation: Add devlink-trap documentation Ido Schimmel
2019-08-13 7:53 ` [PATCH net-next v2 11/14] netdevsim: Add devlink-trap support Ido Schimmel
2019-08-14 23:59 ` Jakub Kicinski
2019-08-15 6:27 ` Ido Schimmel
2019-08-13 7:53 ` [PATCH net-next v2 12/14] Documentation: Add description of netdevsim traps Ido Schimmel
2019-08-13 7:53 ` [PATCH net-next v2 13/14] selftests: devlink_trap: Add test cases for devlink-trap Ido Schimmel
2019-08-15 0:42 ` Jakub Kicinski
2019-08-15 6:34 ` Ido Schimmel [this message]
2019-08-13 7:54 ` [PATCH net-next v2 14/14] Documentation: Add a section for devlink-trap testing Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190815063405.GB12222@splinter \
--to=idosch@idosch.org \
--cc=andrew@lunn.ch \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=idosch@mellanox.com \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@mellanox.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
--cc=toke@redhat.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).