From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E12AC3A589 for ; Thu, 15 Aug 2019 12:36:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1AD492083B for ; Thu, 15 Aug 2019 12:36:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="LmGm2pph" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731846AbfHOMgF (ORCPT ); Thu, 15 Aug 2019 08:36:05 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:34612 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725977AbfHOMgE (ORCPT ); Thu, 15 Aug 2019 08:36:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=97y3ZsRoubOjqu+htEOW1koBAJg5K7XKVQrKOa1Pnzs=; b=LmGm2pphMrn1ja1KJpIgN6nWFU uUJKjCjJf/n3MAiWTOPSYyGxyE4qeiniTvY17RKmYiBcoDiqgZgDrXqaMGYShDF7liRPKZuJQPQ+q SmqVlODqKy0CIFzBGjMGzs66FNOkxHq4T9UP1fPitv8LT6v6l+AiinEYhXzmg632mP6w=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hyEz0-0008Em-VI; Thu, 15 Aug 2019 14:35:58 +0200 Date: Thu, 15 Aug 2019 14:35:58 +0200 From: Andrew Lunn To: Heiner Kallweit Cc: Florian Fainelli , David Miller , "netdev@vger.kernel.org" Subject: Re: [PATCH net-next 2/2] r8169: use the generic EEE management functions Message-ID: <20190815123558.GA31172@lunn.ch> References: <4a6878bf-344e-2df5-df00-b80c7c0982d1@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Aug 15, 2019 at 11:47:33AM +0200, Heiner Kallweit wrote: > Now that the Realtek PHY driver maps the vendor-specific EEE registers > to the standard MMD registers, we can remove all special handling and > use the generic functions phy_ethtool_get/set_eee. Hi Heiner I think you should also add a call the phy_init_eee()? Andrew