From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E630C3A5A0 for ; Mon, 19 Aug 2019 15:58:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 33D6522CED for ; Mon, 19 Aug 2019 15:58:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Dq+rxnHm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727885AbfHSP6I (ORCPT ); Mon, 19 Aug 2019 11:58:08 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:40209 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726390AbfHSP6I (ORCPT ); Mon, 19 Aug 2019 11:58:08 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id EF40721F82; Mon, 19 Aug 2019 11:58:06 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 19 Aug 2019 11:58:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=gpIBDU fEZDWpISBZBKSzckdrBhI7tyEF/XdiR6xtils=; b=Dq+rxnHmDSnDxbOUUxbdOI h+DMsDLbSLEG6axCOcFuszM9/qfiF46JqMt0jSysoMi0sbEp1hpNmBKnWwbW3/Qj os4eZWceQFMejicWLvZKjwoum5c+SFDOsCVY6Ajc8yLmnKzoVKMhzYezxEvjMsRo 1jOtSiiFfYBuAy1ovQv5jENF838z2O+hJTo58edFJKfHpqQCAni0UiyXOrVrT+Uj /ENsgmjmKRWcjTKKAEzCSYbDs0Nj7gncaZy6iBu3AcGEXh8eaNMkSgxKdxsar3/f NNelLraLR4SfSf0llYc2gnUPScMSgpq5wp0fAWNI916fT5deaw2Ktp6E+OkSb6Bg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudefledgleeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujggfsehttd ertddtredvnecuhfhrohhmpefkughoucfutghhihhmmhgvlhcuoehiughoshgthhesihgu ohhstghhrdhorhhgqeenucfkphepudelfedrgeejrdduieehrddvhedunecurfgrrhgrmh epmhgrihhlfhhrohhmpehiughoshgthhesihguohhstghhrdhorhhgnecuvehluhhsthgv rhfuihiivgeptd X-ME-Proxy: Received: from localhost (unknown [193.47.165.251]) by mail.messagingengine.com (Postfix) with ESMTPA id 69D5F380083; Mon, 19 Aug 2019 11:58:05 -0400 (EDT) Date: Mon, 19 Aug 2019 18:58:03 +0300 From: Ido Schimmel To: YueHaibing Cc: davem@davemloft.net, idosch@mellanox.com, jiri@mellanox.com, mcroce@redhat.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, jakub.kicinski@netronome.com Subject: Re: [PATCH net-next] netdevsim: Fix build error without CONFIG_INET Message-ID: <20190819155803.GA16864@splinter> References: <20190819120825.74460-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190819120825.74460-1-yuehaibing@huawei.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Aug 19, 2019 at 08:08:25PM +0800, YueHaibing wrote: > If CONFIG_INET is not set, building fails: > > drivers/net/netdevsim/dev.o: In function `nsim_dev_trap_report_work': > dev.c:(.text+0x67b): undefined reference to `ip_send_check' > > Add CONFIG_INET Kconfig dependency to fix this. > > Reported-by: Hulk Robot > Fixes: da58f90f11f5 ("netdevsim: Add devlink-trap support") > Signed-off-by: YueHaibing Reviewed-by: Ido Schimmel Thanks for the patch. > --- > drivers/net/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig > index 48e209e..7bb786e 100644 > --- a/drivers/net/Kconfig > +++ b/drivers/net/Kconfig > @@ -505,7 +505,7 @@ source "drivers/net/hyperv/Kconfig" > > config NETDEVSIM > tristate "Simulated networking device" > - depends on DEBUG_FS > + depends on INET && DEBUG_FS > select NET_DEVLINK > help > This driver is a developer testing tool and software model that can > -- > 2.7.4 > >