From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CA4FC3A5A0 for ; Tue, 20 Aug 2019 00:07:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F124A22CE8 for ; Tue, 20 Aug 2019 00:07:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="dfIUq6dd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728820AbfHTAHq (ORCPT ); Mon, 19 Aug 2019 20:07:46 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:41639 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728722AbfHTAHp (ORCPT ); Mon, 19 Aug 2019 20:07:45 -0400 Received: by mail-qt1-f196.google.com with SMTP id i4so3995316qtj.8 for ; Mon, 19 Aug 2019 17:07:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=XAiAnlHmkO+0jIPS0nCrMqFBgMcioHrpGQSObqqyeas=; b=dfIUq6ddf9ulKASU6Bv2+Z+qverPNdci02k7EuMkUVkCz1tzrPT2V+peCQB1mSaYn2 WbClo3aQBa1BfkNHVrbwUW9+4yBrOVVxNn+YsIKbgq6VUxYvdz73CgyNgwAxj6PZS5OJ 6JYvvcuEX9N1qMJfiar986WkawCYWvo4FHiHy7AiM8/0h9oRftPVOhvBxSTeWF4NwtEi PWVsa8m13KOJVYNQbzKp+bw38O/l8m3ATDg0lpwP+LdWw3PIL2Oo7j/osajOs2aBlh+6 gS4HOs3nx2YT+WIXvckHc35hK3uAI84RgRaechcT/wEOcLH2DzcowDvWNTiqJIvmRT4W l0Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=XAiAnlHmkO+0jIPS0nCrMqFBgMcioHrpGQSObqqyeas=; b=AsisjJeHu4AXzkONxsIYOvGOZTSdrr7KZs+6uOUPj/IL2A5rGtUPxfzPz6C7AA9hVP BYHymQv36JD9lGT1cKTQzyujcM1vL0KRMmtvlAlm4gH33myRxBfoA3ERFSOVzALzb+Z2 83yslxkMLGtb5kDNOd8wMp2cL8aoC7wxuEQai5zPPxsNfYcoY7utQz5YQfasMVo952C1 y6zv9pieaS3RNBd2QJgDfJEdebIAprsW2xQW5nTH3BCe7KdauiwLKZ/ewsb7a8doAJ4D 62aacqM1ru1JtxyIAVqed+LprJrbwPdJQT2Of0VcPjdi5SXvaVmQDJ4IbZuFI4LFLdvP Hv+A== X-Gm-Message-State: APjAAAV9DzxYO4a1T251vjfBYDq/Cc/ORHofumXh5Qky6sZ0EAHmNrtS +v8QlOCEAGHgx3z54zVXW4DhDA== X-Google-Smtp-Source: APXvYqwGcLBdZK3nU6pGDNftkfkgJPgtpG1aXGPnvYkUGNtX/j6WJIJu/+V0scfWhhEsSLdQ4n5dfw== X-Received: by 2002:aed:27c9:: with SMTP id m9mr23137596qtg.322.1566259664507; Mon, 19 Aug 2019 17:07:44 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id a23sm1283772qtj.5.2019.08.19.17.07.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Aug 2019 17:07:44 -0700 (PDT) Date: Mon, 19 Aug 2019 17:07:35 -0700 From: Jakub Kicinski To: Thomas Bogendoerfer Cc: Jonathan Corbet , Ralf Baechle , Paul Burton , James Hogan , Dmitry Torokhov , Lee Jones , "David S. Miller" , Srinivas Kandagatla , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Evgeniy Polyakov , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-input@vger.kernel.org, netdev@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH v5 12/17] net: sgi: ioc3-eth: use dma-direct for dma allocations Message-ID: <20190819170735.13884ec9@cakuba.netronome.com> In-Reply-To: <20190819163144.3478-13-tbogendoerfer@suse.de> References: <20190819163144.3478-1-tbogendoerfer@suse.de> <20190819163144.3478-13-tbogendoerfer@suse.de> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 19 Aug 2019 18:31:35 +0200, Thomas Bogendoerfer wrote: > @@ -1386,18 +1427,24 @@ static netdev_tx_t ioc3_start_xmit(struct sk_buff *skb, struct net_device *dev) > unsigned long b2 = (data | 0x3fffUL) + 1UL; > unsigned long s1 = b2 - data; > unsigned long s2 = data + len - b2; > + dma_addr_t d; > > desc->cmd = cpu_to_be32(len | ETXD_INTWHENDONE | > ETXD_B1V | ETXD_B2V | w0); > desc->bufcnt = cpu_to_be32((s1 << ETXD_B1CNT_SHIFT) | > (s2 << ETXD_B2CNT_SHIFT)); > - desc->p1 = cpu_to_be64(ioc3_map(skb->data, 1)); > - desc->p2 = cpu_to_be64(ioc3_map((void *)b2, 1)); > + d = dma_map_single(ip->dma_dev, skb->data, s1, DMA_TO_DEVICE); You'll need to check the DMA address with dma_mapping_error(dev, addr), otherwise static checkers will get upset. > + desc->p1 = cpu_to_be64(ioc3_map(d, PCI64_ATTR_PREF)); > + d = dma_map_single(ip->dma_dev, (void *)b2, s1, DMA_TO_DEVICE); > + desc->p2 = cpu_to_be64(ioc3_map(d, PCI64_ATTR_PREF));