From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 505F9C3A5A0 for ; Mon, 19 Aug 2019 17:58:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 29F1B22CEB for ; Mon, 19 Aug 2019 17:58:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G1hJPsmS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728183AbfHSR64 (ORCPT ); Mon, 19 Aug 2019 13:58:56 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:40169 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726959AbfHSR64 (ORCPT ); Mon, 19 Aug 2019 13:58:56 -0400 Received: by mail-qt1-f195.google.com with SMTP id e8so2865584qtp.7; Mon, 19 Aug 2019 10:58:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=NDNJrzj9Dw812qWaq8KwN7iOuvYXUKWq+TvnNgSCkXs=; b=G1hJPsmS3mBTfhzn+i2blZeKrrs67Yzs30PvBA8yh+/ACcVPEKXU7Nlc+myysYX+V+ Jx7P0ksoQOHex3WIGRSW9CdBDHYCKM0CsJlO48kOJtiGGRuAmljBf/4zcsM13YmiOy6J GRZs8UE3h/lN2fTtOTMCorJkhId3YLQP5/TzLNGGsWJfcGJ3vHt8R+QjxzhD8lExjnjs 8bqZp+/xpRYs2TbbSmgSyqvKiaR7PvDgA2ehN93imkNeS6jWKhMqzbh+LY3yTlQtdTir CP6XdQ1iRKxh+mpxjfUIPPTzh85DSkMvYQdQk4vE7tcZb/nlnEdewCTW6Fb3e7WGzeaa X03w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=NDNJrzj9Dw812qWaq8KwN7iOuvYXUKWq+TvnNgSCkXs=; b=hv21H4RHCWBY+VR7pIL0CNxXeZvCoyy1d7qpJrNA3vLJHVnT6BGrXTwjicL8Gv8Dsk 8uQ90blNFaEIppODtpOaTfYWaO6baIeiS9qyDnO76csgiQp8jvcNc9OS6/Ng/VgLz3gC rW99v98i60PF+2hYvctko4D4r/xRFqw+7nSu5MsC8v6fVzrf3olECpUOpHlUbV4Z2iIG dCddQDV/SASu6YHH7cBBr3uT10USRir8dUGlM5erzlQWV3NK2qq7e2zwj5Sz2+fUK68u CE3YD2b6p5XcUDWRSRUnTeD0bbn2ToKWdu/uoDD9Z/abgskHk1sXW3S/AIBkJVo/LPyv Mc5w== X-Gm-Message-State: APjAAAXduBTMTtzqKyBiVeyQa/0gD5eEWrJj3dt8ax1GEV0iCrfRnIdO w4X2N7gcrAYGOWnZK/7Os+A= X-Google-Smtp-Source: APXvYqysrk/Z1ZFxM3voZVp/K6AyYrhF5y7D159QfVB2zclFYMl8LuPvfRFlWLxYDhI6B1XUJsViVw== X-Received: by 2002:ac8:3258:: with SMTP id y24mr21902824qta.183.1566237535122; Mon, 19 Aug 2019 10:58:55 -0700 (PDT) Received: from localhost.localdomain ([2001:1284:f013:9612:ee2d:14b6:21a2:1362]) by smtp.gmail.com with ESMTPSA id d22sm7194496qto.45.2019.08.19.10.58.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Aug 2019 10:58:54 -0700 (PDT) Received: by localhost.localdomain (Postfix, from userid 1000) id 04CB3C1D94; Mon, 19 Aug 2019 14:58:51 -0300 (-03) Date: Mon, 19 Aug 2019 14:58:51 -0300 From: Marcelo Ricardo Leitner To: Xin Long Cc: network dev , linux-sctp@vger.kernel.org, Neil Horman , davem@davemloft.net Subject: Re: [PATCH net-next 0/8] sctp: support per endpoint auth and asconf flags Message-ID: <20190819175851.GF2870@localhost.localdomain> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Aug 19, 2019 at 10:02:42PM +0800, Xin Long wrote: > This patchset mostly does 3 things: > > 1. add per endpint asconf flag and use asconf flag properly > and add SCTP_ASCONF_SUPPORTED sockopt. > 2. use auth flag properly and add SCTP_AUTH_SUPPORTED sockopt. > 3. remove the 'global feature switch' to discard chunks. What about net->sctp.addip_noauth, why wasn't it included as well? I'm thinking that's because it's more of a compatibility knob and that there isn't much value on having it more fine-grained than per-netns. Just feels a bit odd to have the other two but not this one, which is directly related, but yeah. Otherwise, changes LGTM.