From: David Miller <davem@davemloft.net>
To: uli+renesas@fpond.eu
Cc: linux-renesas-soc@vger.kernel.org, netdev@vger.kernel.org,
sergei.shtylyov@cogentembedded.com,
niklas.soderlund@ragnatech.se, wsa@the-dreams.de,
horms@verge.net.au, magnus.damm@gmail.com, geert@glider.be
Subject: Re: [PATCH v3] ravb: implement MTU change while device is up
Date: Tue, 20 Aug 2019 14:05:11 -0700 (PDT) [thread overview]
Message-ID: <20190820.140511.46557475142867394.davem@davemloft.net> (raw)
In-Reply-To: <1566327686-8996-1-git-send-email-uli+renesas@fpond.eu>
From: Ulrich Hecht <uli+renesas@fpond.eu>
Date: Tue, 20 Aug 2019 21:01:26 +0200
> This revision reverts the MTU change if re-opening the device fails.
But you leave the device closed if this happens.
You have to implement this properly, with a full prepare/commit sequence.
First allocate all of the necessary resources, such that you can guarantee
success. If you cannot allocate these resources you must fail the operation
and leave the device _UP_ with the original MTU value.
If you can allocate the resource, you can fully commit to the MTU change
and return success.
You must not fail the operation in such a way that the device is left
inoperable. But that is precisely what your patch currently does.
prev parent reply other threads:[~2019-08-20 21:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 19:01 [PATCH v3] ravb: implement MTU change while device is up Ulrich Hecht
2019-08-20 19:41 ` Wolfram Sang
2019-08-20 21:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190820.140511.46557475142867394.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=geert@glider.be \
--cc=horms@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=uli+renesas@fpond.eu \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).