From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3186C3A589 for ; Tue, 20 Aug 2019 23:58:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BB8F2206B6 for ; Tue, 20 Aug 2019 23:58:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726483AbfHTX6f (ORCPT ); Tue, 20 Aug 2019 19:58:35 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:53104 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726141AbfHTX6f (ORCPT ); Tue, 20 Aug 2019 19:58:35 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 4E7C814B4DFDE; Tue, 20 Aug 2019 16:58:35 -0700 (PDT) Date: Tue, 20 Aug 2019 16:58:34 -0700 (PDT) Message-Id: <20190820.165834.1420751898749952901.davem@davemloft.net> To: willy@infradead.org Cc: netdev@vger.kernel.org Subject: Re: [PATCH 29/38] cls_flower: Convert handle_idr to XArray From: David Miller In-Reply-To: <20190820223259.22348-30-willy@infradead.org> References: <20190820223259.22348-1-willy@infradead.org> <20190820223259.22348-30-willy@infradead.org> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 20 Aug 2019 16:58:35 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Matthew Wilcox Date: Tue, 20 Aug 2019 15:32:50 -0700 > - idr_replace(&head->handle_idr, fnew, fnew->handle); > + xa_store(&head->filters, fnew->handle, fnew, 0); Passing a gfp_t of zero? :-)