From: Dan Carpenter <dan.carpenter@oracle.com>
To: Catherine Sullivan <csully@google.com>
Cc: Sagi Shahar <sagis@google.com>, Jon Olson <jonolson@google.com>,
"David S. Miller" <davem@davemloft.net>,
Willem de Bruijn <willemb@google.com>,
Luigi Rizzo <lrizzo@google.com>,
Chuhong Yuan <hslester96@gmail.com>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH v2 net] gve: Copy and paste bug in gve_get_stats()
Date: Tue, 20 Aug 2019 12:11:44 +0300 [thread overview]
Message-ID: <20190820090739.GB1845@kadam> (raw)
In-Reply-To: <20190820090053.GA24410@mwanda>
There is a copy and paste error so we have "rx" where "tx" was intended
in the priv->tx[] array.
Fixes: f5cedc84a30d ("gve: Add transmit and receive support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
v2: fix a typo in the subject: buy -> bug (Thanks Walter Harms)
drivers/net/ethernet/google/gve/gve_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/google/gve/gve_main.c b/drivers/net/ethernet/google/gve/gve_main.c
index 497298752381..aca95f64bde8 100644
--- a/drivers/net/ethernet/google/gve/gve_main.c
+++ b/drivers/net/ethernet/google/gve/gve_main.c
@@ -50,7 +50,7 @@ static void gve_get_stats(struct net_device *dev, struct rtnl_link_stats64 *s)
u64_stats_fetch_begin(&priv->tx[ring].statss);
s->tx_packets += priv->tx[ring].pkt_done;
s->tx_bytes += priv->tx[ring].bytes_done;
- } while (u64_stats_fetch_retry(&priv->rx[ring].statss,
+ } while (u64_stats_fetch_retry(&priv->tx[ring].statss,
start));
}
}
--
2.20.1
next prev parent reply other threads:[~2019-08-20 9:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 9:00 [PATCH net] gve: Copy and paste buy in gve_get_stats() Dan Carpenter
2019-08-20 9:11 ` Dan Carpenter [this message]
2019-08-21 17:20 ` [PATCH v2 net] gve: Copy and paste bug " Catherine Sullivan
2019-08-22 3:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190820090739.GB1845@kadam \
--to=dan.carpenter@oracle.com \
--cc=csully@google.com \
--cc=davem@davemloft.net \
--cc=hslester96@gmail.com \
--cc=jonolson@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lrizzo@google.com \
--cc=netdev@vger.kernel.org \
--cc=sagis@google.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).